Skip to content

Stack overflow on 'resolveName' for circular default type argument #16533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Jun 14, 2017 · 4 comments
Closed

Stack overflow on 'resolveName' for circular default type argument #16533

DanielRosenwasser opened this issue Jun 14, 2017 · 4 comments
Labels
Bug A bug in TypeScript
Milestone
Backlog

Comments

@DanielRosenwasser
Copy link
Member

Appears in 2.4 RC, nightlies, 2.3.

class Foo<F = Foo> {
}
  1. Get quick info on Foo.
  2. This 
    [Error - 2:31:05 PM] 'quickinfo' request failed with error.
Error processing request. Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
    at resolveNameHelper (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:23632:35)
    at resolveName (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:23630:20)
    at resolveEntityName (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:24161:26)
    at resolveTypeReferenceName (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:28456:20)
    at getTypeFromTypeReference (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:28535:30)
    at getTypeFromTypeNode (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:29326:28)
    at getDefaultFromTypeParameter (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:27767:66)
    at getMinTypeArgumentCount (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:28013:26)
    at getTypeFromClassOrInterfaceReference (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:28384:44)
    at getTypeReferenceTypeWorker (C:\Program Files\nodejs\node_modules\typescript\lib\tsserver.js:28482:24)
@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Jun 14, 2017
@mhegazy mhegazy added this to the TypeScript 2.5 milestone Jun 14, 2017
@jcalz
Copy link
Contributor

jcalz commented Jun 14, 2017

#16221 ?

@mhegazy
Copy link
Contributor

mhegazy commented Jun 14, 2017

indeed. thanks.

@mhegazy mhegazy closed this as completed Jun 14, 2017
@mhegazy mhegazy added Duplicate An existing issue was already created and removed Bug A bug in TypeScript labels Jun 14, 2017
@mhegazy mhegazy removed this from the TypeScript 2.5 milestone Jun 14, 2017
@DanielRosenwasser
Copy link
Member Author

Looks like two related but technically different issues according to @rbuckton

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Fixed A PR has been merged for this issue and removed Duplicate An existing issue was already created Fixed A PR has been merged for this issue labels Jun 15, 2017
@ikatyang ikatyang mentioned this issue Jul 10, 2017
Closed
@MarcusLongmuir MarcusLongmuir mentioned this issue Jul 12, 2017
Closed
@ikatyang ikatyang mentioned this issue Jul 13, 2017
Closed
@mhegazy mhegazy added this to the Future milestone Aug 31, 2017
@jcalz jcalz mentioned this issue Sep 4, 2017
Closed
@duvet86 duvet86 mentioned this issue Dec 1, 2018
Closed
@DanielRosenwasser
Copy link
Member Author

Looks fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jcalz @DanielRosenwasser @rbuckton @mhegazy