Skip to content

Autoimport does not respect TS re-export files #19888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjbvz opened this issue Nov 9, 2017 · 3 comments
Closed

Autoimport does not respect TS re-export files #19888

mjbvz opened this issue Nov 9, 2017 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 9, 2017

From @artaommahe on November 9, 2017 11:25

  • VSCode Version: 1.18.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. e.x. angular app, write Component
  2. press enter for autocomplete/autoimport
  3. see
import { Component } from "@angular/core/src/metadata/directives";

expected

import { Component } from "@angular/core";

Reproduces without extensions: Yes

Copied from original issue: microsoft/vscode#37926
@mjbvz mjbvz self-assigned this Nov 9, 2017
@mjbvz
Copy link
Contributor Author

mjbvz commented Nov 9, 2017

From @artaommahe on November 9, 2017 11:28

Cant repoduce it with in-project re-export files. Looks like it's wrong only for lib imports

@mjbvz mjbvz mentioned this issue Nov 9, 2017
Closed
@mjbvz mjbvz removed the typescript label Nov 9, 2017
@mjbvz mjbvz removed their assignment Nov 9, 2017
@mjbvz
Copy link
Contributor Author

mjbvz commented Nov 9, 2017

Possibly another dup of #17705

@ghost ghost self-assigned this Nov 10, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Nov 10, 2017

seems like a duplicate of #19889 #19889 and #19922 and #17705

@mhegazy mhegazy added the Duplicate An existing issue was already created label Nov 10, 2017
@mhegazy mhegazy unassigned ghost Nov 10, 2017
@mhegazy mhegazy mentioned this issue Nov 10, 2017
Closed
@ghost ghost mentioned this issue Nov 15, 2017
Merged
@ghost ghost closed this as completed in #20049 Nov 17, 2017
This was referenced Dec 8, 2017
Closed
Closed
@aeslinger0 aeslinger0 mentioned this issue Dec 28, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Duplicate An existing issue was already created
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhegazy @mjbvz