Skip to content

Error: Debug Failure. False expression. in 'findPrecedingToken' during 'quickinfo' #21799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aozgaa opened this issue Feb 9, 2018 · 5 comments
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created Source: Telemetry The issue relates to the telemetry in editors

Comments

@aozgaa
Copy link
Contributor

aozgaa commented Feb 9, 2018

This issue comes from crash dumps in telemetry. We've tried to de-duplicate issues on a best-effort basis, comparing the sequence of methods called and the command requested while ignoring line numbers.
TypeScript Version Prefix: 2.7.1
VSCode Version 1.19.1
command requested: quickinfo
hitting sessions: 1327
proportion of all sessions: 0.004953840066001426
five line hash: ef1e8036c3984084e264fb3559d7e8b2
stack

Error: Debug Failure. False expression.
    at findPrecedingToken (tsserver.js:64624:18)
    at getTokenAtPositionWorker (tsserver.js:64586:41)
    at getTouchingToken (tsserver.js:64558:16)
    at Object.getTouchingPropertyName (tsserver.js:64554:16)
    at getQuickInfoAtPosition (tsserver.js:82852:27)
    at Object.getQuickInfoAtPosition (template-language-service-decorator.js:56:24)
    at IOSession.Session.getQuickInfoWorker (tsserver.js:89781:62)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (tsserver.js:88934:61)
    at unknown (tsserver.js:90355:88)
    at IOSession.Session.executeWithRequestId (tsserver.js:90346:28)
    at IOSession.Session.executeCommand (tsserver.js:90355:33)
    at IOSession.Session.onMessage (tsserver.js:90375:35)
    at Interface.<anonymous> (tsserver.js:91576:27)
    at emitOne (events.js:96:13)
    at Interface.emit (events.js:191:7)
    at Interface._onLine (readline.js:241:10)
    at Interface._normalWrite (readline.js:384:12)
    at Socket.ondata (readline.js:101:10)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)
@ghost
Copy link

ghost commented Feb 9, 2018

@aozgaa The line numbers don't seem to match 2.7.1, is this possibly an older or newer version?

@aozgaa
Copy link
Contributor Author

aozgaa commented Feb 9, 2018

It could be an insiders build whose version starts with 2.7.1. I could try to get the exact version in the future, but requires some work. How useful would that be, on a scale from 1-10?

@mhegazy
Copy link
Contributor

mhegazy commented Feb 9, 2018

Insider builds have different version anyways. this could either be 2.7.1 or a local build. We have changed the version in master, so moving forward we should not have this confusion.

@ghost ghost added Fixed A PR has been merged for this issue and removed Fixed A PR has been merged for this issue labels Feb 9, 2018
@ghost
Copy link

ghost commented Feb 12, 2018

Looks like a duplicate of #20788.

@ghost ghost closed this as completed Feb 12, 2018
@ghost ghost added the Duplicate An existing issue was already created label Feb 12, 2018
@aozgaa
Copy link
Contributor Author

aozgaa commented Mar 5, 2018

This issue reproduced in the following context:
TypeScript Version Prefix: 2.7.2
VSCode Version 1.21.0-insider
command requested: quickinfo
hitting sessions: 435
proportion of all sessions: 0.008930587776386294
stack

Error: Debug Failure. False expression.
    at findPrecedingToken (tsserver.js:64794:18)
    at getTokenAtPositionWorker (tsserver.js:64756:41)
    at getTouchingToken (tsserver.js:64728:16)
    at Object.getTouchingPropertyName (tsserver.js:64724:16)
    at getQuickInfoAtPosition (tsserver.js:83050:27)
    at Object.getQuickInfoAtPosition (template-language-service-decorator.js:59:24)
    at IOSession.Session.getQuickInfoWorker (tsserver.js:89979:62)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (tsserver.js:89132:61)
    at unknown (tsserver.js:90553:88)
    at IOSession.Session.executeWithRequestId (tsserver.js:90544:28)
    at IOSession.Session.executeCommand (tsserver.js:90553:33)
    at IOSession.Session.onMessage (tsserver.js:90573:35)
    at Interface.<anonymous> (tsserver.js:91774:27)
    at emitOne (events.js:96:13)
    at Interface.emit (events.js:191:7)
    at Interface._onLine (readline.js:241:10)
    at Interface._normalWrite (readline.js:384:12)
    at Socket.ondata (readline.js:101:10)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)

@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created Source: Telemetry The issue relates to the telemetry in editors
Projects
None yet
Development

No branches or pull requests

2 participants