Skip to content

Typo in emitDeclarationError for declarations #22425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
obany opened this issue Mar 9, 2018 · 2 comments
Closed

Typo in emitDeclarationError for declarations #22425

obany opened this issue Mar 9, 2018 · 2 comments
Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Milestone
TypeScript 2.8

Comments

@obany
Copy link
Contributor

obany commented Mar 9, 2018

TypeScript Version: 2.7.2

Search Terms: emitDeclarationOnly

Code

https://github.com/Microsoft/TypeScript/blob/fa4619c5c17a6a592245069f416b91e2ea40c36d/src/compiler/program.ts#L2202-L2205

error TS5052: Option 'emitDeclarationOnly' cannot be specified without specifying option 'declarations'.

Expected behavior:
Should say
error TS5052: Option 'emitDeclarationOnly' cannot be specified without specifying option 'declaration'.

Actual behavior:
Says 'declarations'
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Help Wanted You can do this Good First Issue Well scoped, documented and has the green light Domain: Error Messages The issue relates to error messaging labels Mar 9, 2018
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Mar 9, 2018 •
edited
Loading

We'd take a PR! Should be a matter of changing diagnosticMessages.json, running jake generate-diagnostics, updating the references to the error, running the tests, and updating our test baselines' output (if we had any tests for this).

@mhegazy mhegazy added this to the Community milestone Mar 9, 2018
@obany obany mentioned this issue Mar 9, 2018
Merged
@obany
Copy link
Contributor Author

obany commented Mar 9, 2018

PR Submitted #22444

@mhegazy mhegazy modified the milestones: Community, TypeScript 2.8.1 Mar 9, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 9, 2018
@brainkim brainkim mentioned this issue Jul 4, 2018
Closed
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.8
Development

No branches or pull requests
3 participants
@DanielRosenwasser @obany @mhegazy