Skip to content

getApplicableRefactors on file with recursive types freezes TSServer #26833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlCalzone opened this issue Sep 1, 2018 · 1 comment · Fixed by #32944
Closed

getApplicableRefactors on file with recursive types freezes TSServer #26833

AlCalzone opened this issue Sep 1, 2018 · 1 comment · Fixed by #32944
Labels
Needs More Info The issue still hasn't been fully clarified

Comments

@AlCalzone
Copy link
Contributor

TypeScript Version: 3.1.0-dev.20180901

Search Terms: none

When working on a file with several recursive types, the TSServer process got stuck in an endless loop and continued building up memory. Later this error showed up in the error console in VSCode:

[Info  - 10:12:55 AM] Using tsserver from: c:\Users\domin\Documents\Visual Studio 2017\Repositories\shared-utils\node_modules\typescript\lib
[Error  - 10:12:55 AM] 'getApplicableRefactors' request failed with error.
Error: Service died.
	at TypeScriptServiceClient.serviceExited (c:\Users\domin\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\out\typescriptServiceClient.js:413:32)
	at ChildProcess.handle.onExit (c:\Users\domin\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\out\typescriptServiceClient.js:326:30)
	at emitTwo (events.js:131:20)
	at ChildProcess.emit (events.js:214:7)
	at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)

Related Issues: #26155
@RyanCavanaugh RyanCavanaugh added the Needs More Info The issue still hasn't been fully clarified label Sep 17, 2018
@AlCalzone
Copy link
Contributor Author

Cannot reproduce atm, closing for now.

@sandersn sandersn mentioned this issue Aug 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs More Info The issue still hasn't been fully clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Constructor functions as classes microsoft/TypeScript
2 participants
@RyanCavanaugh @AlCalzone