-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Provide a quick-fix for non-exported types #37440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@DanielRosenwasser / @RyanCavanaugh I can get time and work on this. Quick question, which files generally have the code for Domain "Quick Fixes"? |
It's all in class C {
foo = 10;
bar() {
foo; // oops! needs to be prefixed with `this.`
}
} |
Sorry, I meant |
Thanks a lot :) |
@AGMETEOR Are you still working on this issue? If not, I'm looking for an opportunity to begin contributing. :) |
@JJPIV yes, I am working on it |
@JJPIV please take this on if you still want to. |
@JJPIV Did you take this? If not I'd like to take a shot :) |
I'm working on this issue, currently stuck at getting SourceFile object for
|
@Qiyu8 I think that information is in the context that's passed to |
@AGMETEOR Thanks for your advise, would you mind reviewing the code? |
@Qiyu8 I think @DanielRosenwasser is the one that reviews. I am also still quite a new contributor :) |
I assume nobody is working on this at the moment? If so, I would like to take a shot @DanielRosenwasser |
Thank you @a-tarasyuk! |
In #36187, @a-tarasyuk wrote up a handy error message for non-exported types. We should provide a quick fix to add the
export
modifier for declarations like this that aren't innode_modules
and the like.The text was updated successfully, but these errors were encountered: