Skip to content

'npm install knex' causes BigInt to be valid in all JS files #37986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Apr 15, 2020 · 2 comments
Closed

'npm install knex' causes BigInt to be valid in all JS files #37986

mjbvz opened this issue Apr 15, 2020 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 15, 2020

microsoft/vscode#95187

TypeScript Version: 3.9.0-dev.20200413

Search Terms:

  • bigint
  • npm install
  • javascript

Code
For the JS:

// @ts-check

export const a = 1;

BigInt(1)
  1. See error reported about BigInt since we are targeting es6 by default
  2. Now run npm install knex

Bug:
The error goes away after the install

Go to definition on BigInt goes to lib.es2020.bigint.d.ts

@RyanCavanaugh
Copy link
Member

See #37775

@RyanCavanaugh RyanCavanaugh added the Duplicate An existing issue was already created label Apr 15, 2020
@typescript-bot
Copy link
Collaborator

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants