Skip to content

The grammar prohibits optional parameters with a string literal type #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JsonFreeman opened this issue Aug 7, 2014 · 0 comments
Closed

The grammar prohibits optional parameters with a string literal type #399

JsonFreeman opened this issue Aug 7, 2014 · 0 comments
Assignees
@ahejlsberg
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Spec Issues related to the TypeScript language specification
Milestone
TypeScript 1.1

Comments

@JsonFreeman
Copy link
Contributor

The grammar prohibits the following signature:

(x?: "hi");

But both implementations allow it, and it is reasonable. The nonterminal OptionalParameter needs to be augmented to allow it.
@mhegazy mhegazy added this to the TypeScript 1.1 milestone Aug 8, 2014
@mhegazy mhegazy added the Bug label Aug 8, 2014
@ahejlsberg ahejlsberg mentioned this issue Sep 3, 2014
Merged
@RyanCavanaugh RyanCavanaugh added the Fixed A PR has been merged for this issue label Sep 11, 2014
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ahejlsberg ahejlsberg

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Spec Issues related to the TypeScript language specification
Projects
None yet
Milestone
TypeScript 1.1
Development

No branches or pull requests
4 participants
@ahejlsberg @RyanCavanaugh @mhegazy @JsonFreeman