Skip to content

Capture more info in TS Server errors to help provide repros #45900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewbranch opened this issue Sep 15, 2021 · 3 comments
Closed

Capture more info in TS Server errors to help provide repros #45900

andrewbranch opened this issue Sep 15, 2021 · 3 comments
Assignees
Labels
Infrastructure Issue relates to TypeScript team infrastructure Rescheduled This issue was previously scheduled to an earlier milestone

Comments

@andrewbranch
Copy link
Member

When TS Server crashes / issues an error response, VS Code will prompt users to open an issue with the error stack under some circumstances: https://github.com/microsoft/vscode/blob/4fcbe9449c57ff1e65f134dde6df58cb28bcea5f/extensions/typescript-language-features/src/typescriptServiceClient.ts#L988

Many of these users open the issue, but don’t fill out other info in the template, and don’t respond to requests for more information. TS Server could provide more info about its current state in its error response to help make these issues easier to reproduce, even if the user is unresponsive. What I want most right now is a list of dependencies being processed when the stack mentions AutoImportProviderProject: see #45874. @DanielRosenwasser suggested it might be possible to include the last few commands that the server processed.

@andrewbranch andrewbranch added the Infrastructure Issue relates to TypeScript team infrastructure label Sep 15, 2021
@andrewbranch andrewbranch added this to the TypeScript 4.6.0 milestone Sep 15, 2021
@andrewbranch andrewbranch self-assigned this Sep 15, 2021
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Sep 16, 2021

@DanielRosenwasser suggested it might be possible to include the last few commands that the server processed.

I would be interested in being able to see the last few files that got "jumped to" within the checker etc. Maybe some way to track calls to host.getSourceFile. It's not always a direct trail, but it could be useful.

@DanielRosenwasser
Copy link
Member

I wonder if users would be able to provide a repro more easily if we were able to tell them what file and range was requested (if that's relevant)

@RyanCavanaugh RyanCavanaugh added the Rescheduled This issue was previously scheduled to an earlier milestone label May 13, 2022
@andrewbranch
Copy link
Member Author

We can come back to this if needed, but I’m going to close it out given our recent success in finding repros via better TS Server fuzzer scenarios.

@andrewbranch andrewbranch closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
Development

No branches or pull requests

3 participants