Skip to content

Investigate memory jump from "Avoid unnecessary buildInfo read if host supports caching it" #51531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielRosenwasser opened this issue Nov 14, 2022 · 2 comments
Assignees
Labels
Domain: Performance Reports of unusually slow behavior

Comments

@DanielRosenwasser
Copy link
Member

We seem to have a 1.8% jump in memory usage on the material-ui benchmark introduced by #51403. We should probably try to handle that

image

@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.0.1 milestone Nov 14, 2022
@DanielRosenwasser DanielRosenwasser added the Domain: Performance Reports of unusually slow behavior label Nov 14, 2022
@sheetalkamat
Copy link
Member

Doesnt seem like the root cause:

On main these are the results:


Files:                        1093
Lines of Library:            27092
Lines of Definitions:       119292
Lines of TypeScript:         33066
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Identifiers:                213300
Symbols:                    777348
Types:                      259810
Instantiations:            1785634
Memory used:               621056K
Assignability cache size:   136815
Identity cache size:        181235
Subtype cache size:          31917
Strict subtype cache size:    1979
I/O Read time:               0.22s
Parse time:                  1.65s
ResolveModule time:          1.03s
ResolveTypeReference time:   0.06s
Program time:                3.36s
Bind time:                   0.65s
Check time:                 20.10s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                 24.11s

Found 139 errors.

Projects in scope:                         1
Projects built:                            1
Aggregate Files:                        1093
Aggregate Lines of Library:            27092
Aggregate Lines of Definitions:       119292
Aggregate Lines of TypeScript:         33066
Aggregate Lines of JavaScript:             0
Aggregate Lines of JSON:                   0
Aggregate Lines of Other:                  0
Aggregate Identifiers:                213300
Aggregate Symbols:                    777348
Aggregate Types:                      259810
Aggregate Instantiations:            1785634
Aggregate Memory used:               621056K
Aggregate Assignability cache size:   136815
Aggregate Identity cache size:        181235
Aggregate Subtype cache size:          31917
Aggregate Strict subtype cache size:    1979
Aggregate I/O Read time:               0.22s
Aggregate Parse time:                  1.65s
Aggregate ResolveModule time:          1.03s
Aggregate ResolveTypeReference time:   0.06s
Aggregate Program time:                3.36s
Aggregate Bind time:                   0.65s
Aggregate Check time:                 20.10s
Aggregate printTime time:              0.00s
Aggregate Emit time:                   0.00s
Config file parsing time:              0.10s
Up-to-date check time:                 0.05s
Build time:                           24.98s

While i reverted the PR and ran the benchmark and the results are:


Files:                        1093
Lines of Library:            27092
Lines of Definitions:       119292
Lines of TypeScript:         33066
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Identifiers:                213300
Symbols:                    777348
Types:                      259810
Instantiations:            1785634
Memory used:               621078K
Assignability cache size:   136815
Identity cache size:        181235
Subtype cache size:          31917
Strict subtype cache size:    1979
I/O Read time:               0.22s
Parse time:                  1.67s
ResolveModule time:          1.02s
ResolveTypeReference time:   0.06s
Program time:                3.38s
Bind time:                   0.66s
Check time:                 20.66s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                 24.70s

Found 139 errors.

Projects in scope:                         1
Projects built:                            1
Aggregate Files:                        1093
Aggregate Lines of Library:            27092
Aggregate Lines of Definitions:       119292
Aggregate Lines of TypeScript:         33066
Aggregate Lines of JavaScript:             0
Aggregate Lines of JSON:                   0
Aggregate Lines of Other:                  0
Aggregate Identifiers:                213300
Aggregate Symbols:                    777348
Aggregate Types:                      259810
Aggregate Instantiations:            1785634
Aggregate Memory used:               621078K
Aggregate Assignability cache size:   136815
Aggregate Identity cache size:        181235
Aggregate Subtype cache size:          31917
Aggregate Strict subtype cache size:    1979
Aggregate I/O Read time:               0.22s
Aggregate Parse time:                  1.67s
Aggregate ResolveModule time:          1.02s
Aggregate ResolveTypeReference time:   0.06s
Aggregate Program time:                3.38s
Aggregate Bind time:                   0.66s
Aggregate Check time:                 20.66s
Aggregate printTime time:              0.00s
Aggregate Emit time:                   0.00s
Config file parsing time:              0.10s
Up-to-date check time:                 0.06s
Build time:                           25.64s

@sheetalkamat
Copy link
Member

Run on #51730 (comment) suggest same thing ?
cc: @DanielRosenwasser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Performance Reports of unusually slow behavior
Projects
None yet
Development

No branches or pull requests

2 participants