Skip to content

[spec] Grammar says ambient enum member can be an arbitrary numeric literal #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhegazy opened this issue Aug 26, 2014 · 0 comments
Closed

[spec] Grammar says ambient enum member can be an arbitrary numeric literal #546

mhegazy opened this issue Aug 26, 2014 · 0 comments
Assignees
@ahejlsberg
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Spec Issues related to the TypeScript language specification
Milestone
TypeScript 1.1

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Aug 26, 2014

AmbientEnumMember says

PropertyName = NumericLiteral

when in truth this is not quite right. NumericLiteral allows decimals, but does not allow negatives. The one we need is SignedInteger or HexIntegerLiteral from the ES spec.
@sophiajt sophiajt added this to the TypeScript 1.1 milestone Aug 26, 2014
@ahejlsberg ahejlsberg mentioned this issue Sep 3, 2014
Merged
@RyanCavanaugh RyanCavanaugh added the Fixed A PR has been merged for this issue label Sep 11, 2014
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ahejlsberg ahejlsberg

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Spec Issues related to the TypeScript language specification
Projects
None yet
Milestone
TypeScript 1.1
Development

No branches or pull requests
4 participants
@sophiajt @ahejlsberg @RyanCavanaugh @mhegazy