Repository navigation
fix(38295): Duplicated object key in const not detected when the key is a number preceded by - or + - #38607
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoMay 20, 2020
Conversation
Nathan Shively-Sanders (sandersn)
requested changes
May 19, 2020
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
The positive case is more complicated than the current implementation.
| !!! error TS2300: Duplicate identifier '[-1]'. | ||
| } | ||
|
|
||
| const c = { |
There was a problem hiding this comment.
I don't think this should be an error; at least on node it's fine:
> { "+1": 1, [+1]: 2 }
{ '1': 2, '+1': 1 }
There was a problem hiding this comment.
Yep, this case should instead be "1"/[+1] and also 1/[+1].
Contributor
Author
There was a problem hiding this comment.
Nathan Shively-Sanders (@sandersn) Thanks for the feedback
Nathan Shively-Sanders (sandersn)
added
the
For Backlog Bug
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/38295
branch
from
May 20, 2020 11:33
2395fda to
e04ab69
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Nathan Shively-Sanders (sandersn)
May 20, 2020 12:21
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/38295
branch
from
May 20, 2020 17:13
6ea3aff to
e04ab69
Compare
Nathan Shively-Sanders (sandersn)
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38295