Skip to content

Commit b1b4d18

Browse files
Merge pull request #1642: Update Git to v2.26.0
See microsoft/git#251 for details. This required an update to our test infrastructure. The rebase merge backend changed in a way that it would now open an editor during `git rebase --continue`, causing a test to wait for `vim` to close. Set the editor to be a no-op. This also changes the output to include the commit oid, so use `GIT_COMMITTER_TIME` to be a constant to keep the commits the same.
2 parents c1aa0e9 + 56c838f commit b1b4d18

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

GVFS/GVFS.Build/GVFS.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
<PropertyGroup Label="Parameters">
55
<GVFSVersion>0.2.173.2</GVFSVersion>
6-
<GitPackageVersion>2.20200221.5</GitPackageVersion>
6+
<GitPackageVersion>2.20200323.8</GitPackageVersion>
77
</PropertyGroup>
88

99
<PropertyGroup Label="DefaultSettings">

GVFS/GVFS.FunctionalTests/Tests/GitCommands/GitRepoTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using GVFS.Tests.Should;
66
using NUnit.Framework;
77
using System;
8-
using System.Collections.Generic;
98
using System.IO;
109
using System.Linq;
1110

@@ -204,6 +203,7 @@ protected void CreateEnlistment(string commitish = null)
204203
{
205204
this.Enlistment = GVFSFunctionalTestEnlistment.CloneAndMount(GVFSTestConfig.PathToGVFS, commitish: commitish);
206205
GitProcess.Invoke(this.Enlistment.RepoRoot, "config advice.statusUoption false");
206+
GitProcess.Invoke(this.Enlistment.RepoRoot, "config core.editor true");
207207
this.ControlGitRepo = ControlGitRepo.Create(commitish);
208208
this.ControlGitRepo.Initialize();
209209
}

GVFS/GVFS.FunctionalTests/Tools/ControlGitRepo.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
using GVFS.FunctionalTests.FileSystemRunners;
2-
using System;
1+
using System;
32
using System.IO;
4-
using System.Runtime.InteropServices;
53

64
namespace GVFS.FunctionalTests.Tools
75
{
@@ -52,6 +50,7 @@ public void Initialize()
5250
Directory.CreateDirectory(this.RootPath);
5351
GitProcess.Invoke(this.RootPath, "init");
5452
GitProcess.Invoke(this.RootPath, "config core.autocrlf false");
53+
GitProcess.Invoke(this.RootPath, "config core.editor true");
5554
GitProcess.Invoke(this.RootPath, "config merge.stat false");
5655
GitProcess.Invoke(this.RootPath, "config merge.renames false");
5756
GitProcess.Invoke(this.RootPath, "config advice.statusUoption false");

GVFS/GVFS.FunctionalTests/Tools/GitHelpers.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ public static void ValidateGitCommand(
123123

124124
Dictionary<string, string> environmentVariables = new Dictionary<string, string>();
125125
environmentVariables["GIT_QUIET"] = "true";
126+
environmentVariables["GIT_COMMITTER_DATE"] = "Thu Feb 16 10:07:35 2017 -0700";
126127

127128
ProcessResult expectedResult = GitProcess.InvokeProcess(controlRepoRoot, command, environmentVariables);
128129
ProcessResult actualResult = GitHelpers.InvokeGitAgainstGVFSRepo(gvfsRepoRoot, command, environmentVariables);

0 commit comments

Comments
 (0)