Merge pull request #1020: GitAuthentication: do not trace credential data

jrbriggs · web-flow · commit be3eb72aa3ad · 2019-04-09T16:03:24.000-04:00
diff --git a/GVFS/GVFS.Common/Git/GitAuthentication.cs b/GVFS/GVFS.Common/Git/GitAuthentication.cs
@@ -74,7 +74,6 @@ public void ApproveCredentials(ITracer tracer, string credentialString)
                             EventMetadata metadata = new EventMetadata(new Dictionary<string, object>
                             {
                                 ["RepoUrl"] = this.repoUrl,
-                                ["CredentialString"] = this.cachedCredentialString
                             });
                             tracer.RelatedError(metadata, "Failed to parse credential string for approval");
                         }
@@ -106,7 +105,6 @@ public void RejectCredentials(ITracer tracer, string credentialString)
                         EventMetadata metadata = new EventMetadata(new Dictionary<string, object>
                         {
                             ["RepoUrl"] = this.repoUrl,
-                            ["CredentialString"] = this.cachedCredentialString
                         });
                         tracer.RelatedWarning(metadata, "Failed to parse credential string for rejection. Rejecting any credential for this repo URL.");
                         this.git.RejectCredentials(this.repoUrl);

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,6 @@ public void ApproveCredentials(ITracer tracer, string credentialString)`
`74`	`74`	`EventMetadata metadata = new EventMetadata(new Dictionary<string, object>`
`75`	`75`	`{`
`76`	`76`	`["RepoUrl"] = this.repoUrl,`
`77`		`- ["CredentialString"] = this.cachedCredentialString`
`78`	`77`	`});`
`79`	`78`	`tracer.RelatedError(metadata, "Failed to parse credential string for approval");`
`80`	`79`	`}`
`@@ -106,7 +105,6 @@ public void RejectCredentials(ITracer tracer, string credentialString)`
`106`	`105`	`EventMetadata metadata = new EventMetadata(new Dictionary<string, object>`
`107`	`106`	`{`
`108`	`107`	`["RepoUrl"] = this.repoUrl,`
`109`		`- ["CredentialString"] = this.cachedCredentialString`
`110`	`108`	`});`
`111`	`109`	`tracer.RelatedWarning(metadata, "Failed to parse credential string for rejection. Rejecting any credential for this repo URL.");`
`112`	`110`	`this.git.RejectCredentials(this.repoUrl);`