Skip to content

Commit cf53726

Browse files
committed
Remove GVFS.Service.UI (dead code)
The Service.UI process displayed Windows toast notifications, but only the MountFailure notification was actively sent, and it provided no useful value. Removing eliminates XmlSerializer and WinRT COM interop dependencies that would block NativeAOT compilation. Removes: project, unit tests, installer integration, service launch logic, notification handler, diagnostics log collection, and the Microsoft.Windows.SDK.Contracts package. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
1 parent 5bd9825 commit cf53726

26 files changed

Lines changed: 1 addition & 826 deletions

Directory.Packages.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<PackageVersion Include="Microsoft.Windows.ProjFS" Version="1.1.19156.1" />
2929

3030
<!-- Windows -->
31-
<PackageVersion Include="Microsoft.Windows.SDK.Contracts" Version="10.0.17134.1000-preview" />
3231
<PackageVersion Include="System.ServiceProcess.ServiceController" Version="4.5.0" />
3332

3433
<!-- Build / packaging -->

GVFS.sln

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "GVFS.ReadObjectHook", "GVFS
3333
EndProject
3434
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GVFS.Service", "GVFS\GVFS.Service\GVFS.Service.csproj", "{5E236AF3-31D7-4313-A129-F080FF058283}"
3535
EndProject
36-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GVFS.Service.UI", "GVFS\GVFS.Service.UI\GVFS.Service.UI.csproj", "{D8FB16E2-EAE0-4E05-A993-940062CD7CA7}"
37-
EndProject
3836
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GVFS.Tests", "GVFS\GVFS.Tests\GVFS.Tests.csproj", "{FE70E0D6-B0A6-421D-AA12-F28F822F09A0}"
3937
EndProject
4038
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GVFS.UnitTests", "GVFS\GVFS.UnitTests\GVFS.UnitTests.csproj", "{1A46C414-7F39-4EF0-B216-A88033D18678}"
@@ -115,10 +113,6 @@ Global
115113
{5E236AF3-31D7-4313-A129-F080FF058283}.Debug|x64.Build.0 = Debug|Any CPU
116114
{5E236AF3-31D7-4313-A129-F080FF058283}.Release|x64.ActiveCfg = Release|Any CPU
117115
{5E236AF3-31D7-4313-A129-F080FF058283}.Release|x64.Build.0 = Release|Any CPU
118-
{D8FB16E2-EAE0-4E05-A993-940062CD7CA7}.Debug|x64.ActiveCfg = Debug|Any CPU
119-
{D8FB16E2-EAE0-4E05-A993-940062CD7CA7}.Debug|x64.Build.0 = Debug|Any CPU
120-
{D8FB16E2-EAE0-4E05-A993-940062CD7CA7}.Release|x64.ActiveCfg = Release|Any CPU
121-
{D8FB16E2-EAE0-4E05-A993-940062CD7CA7}.Release|x64.Build.0 = Release|Any CPU
122116
{FE70E0D6-B0A6-421D-AA12-F28F822F09A0}.Debug|x64.ActiveCfg = Debug|Any CPU
123117
{FE70E0D6-B0A6-421D-AA12-F28F822F09A0}.Debug|x64.Build.0 = Debug|Any CPU
124118
{FE70E0D6-B0A6-421D-AA12-F28F822F09A0}.Release|x64.ActiveCfg = Release|Any CPU

GVFS/GVFS.Common/GVFSConstants.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public static class Service
6868
{
6969
public const string ServiceName = "GVFS.Service";
7070
public const string LogDirectory = "Logs";
71-
public const string UIName = "GVFS.Service.UI";
7271
}
7372

7473
public static class MediaTypes
@@ -108,7 +107,6 @@ public static class LogFileTypes
108107
public const string Prefetch = "prefetch";
109108
public const string Repair = "repair";
110109
public const string Service = "service";
111-
public const string ServiceUI = "service_ui";
112110
public const string Sparse = "sparse";
113111
public const string UpgradeVerb = UpgradePrefix + "_verb";
114112
public const string UpgradeProcess = UpgradePrefix + "_process";

GVFS/GVFS.Installers/Setup.iss

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#define GVFSConfigFileName "gvfs.config"
1616
#define GVFSStatuscacheTokenFileName "EnableGitStatusCacheToken.dat"
1717
#define ServiceName "GVFS.Service"
18-
#define ServiceUIName "VFS For Git"
1918

2019
[Setup]
2120
AppId={{489CA581-F131-4C28-BE04-4FB178933E6D}
@@ -66,9 +65,6 @@ DestDir: "{app}"; Flags: ignoreversion; Source:"{#LayoutDir}\GVFS.Service.exe";
6665
[Dirs]
6766
Name: "{app}\ProgramData\{#ServiceName}"; Permissions: users-readexec
6867

69-
[Icons]
70-
Name: "{commonstartmenu}\{#ServiceUIName}"; Filename: "{app}\GVFS.Service.UI.exe"; AppUserModelID: "GVFS"
71-
7268
[UninstallDelete]
7369
; Deletes the entire installation directory, including files and subdirectories
7470
Type: filesandordirs; Name: "{app}";
@@ -249,38 +245,6 @@ begin
249245
end;
250246
end;
251247
252-
procedure StartGVFSServiceUI();
253-
var
254-
ResultCode: integer;
255-
begin
256-
if GetEnv('GVFS_UNATTENDED') = '1' then
257-
begin
258-
Log('StartGVFSServiceUI: Skipping launching GVFS.Service.UI');
259-
end
260-
else if ExecAsOriginalUser(ExpandConstant('{app}\GVFS.Service.UI.exe'), '', '', SW_HIDE, ewNoWait, ResultCode) then
261-
begin
262-
Log('StartGVFSServiceUI: Successfully launched GVFS.Service.UI');
263-
end
264-
else
265-
begin
266-
Log('StartGVFSServiceUI: Failed to launch GVFS.Service.UI');
267-
end;
268-
end;
269-
270-
procedure StopGVFSServiceUI();
271-
var
272-
ResultCode: integer;
273-
begin
274-
if Exec('powershell.exe', '-NoProfile "Stop-Process -Name GVFS.Service.UI"', '', SW_HIDE, ewNoWait, ResultCode) then
275-
begin
276-
Log('StopGVFSServiceUI: Successfully stopped GVFS.Service.UI');
277-
end
278-
else
279-
begin
280-
RaiseException('Fatal: Could not stop process: GVFS.Service.UI');
281-
end;
282-
end;
283-
284248
function DeleteFileIfItExists(FilePath: string) : Boolean;
285249
begin
286250
Result := False;
@@ -688,7 +652,6 @@ begin
688652
ssPostInstall:
689653
begin
690654
MigrateConfigAndStatusCacheFiles();
691-
StartGVFSServiceUI();
692655
if ExpandConstant('{param:REMOUNTREPOS|true}') = 'true' then
693656
begin
694657
MountRepos();
@@ -707,7 +670,6 @@ begin
707670
case CurStep of
708671
usUninstall:
709672
begin
710-
StopGVFSServiceUI();
711673
UninstallService('GVFS.Service', False);
712674
RemovePath(ExpandConstant('{app}'));
713675
end;
@@ -731,7 +693,6 @@ begin
731693
Abort();
732694
end;
733695
StopService('GVFS.Service');
734-
StopGVFSServiceUI();
735696
UninstallGvFlt();
736697
UninstallProjFSIfNecessary();
737698
end;

GVFS/GVFS.Payload/GVFS.Payload.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
<ProjectReference Include="..\GVFS.Mount\GVFS.Mount.csproj" />
2323
<ProjectReference Include="..\GVFS.PostIndexChangedHook\GVFS.PostIndexChangedHook.vcxproj" />
2424
<ProjectReference Include="..\GVFS.ReadObjectHook\GVFS.ReadObjectHook.vcxproj" />
25-
<ProjectReference Include="..\GVFS.Service.UI\GVFS.Service.UI.csproj" />
2625
<ProjectReference Include="..\GVFS.Service\GVFS.Service.csproj" />
2726
<ProjectReference Include="..\GVFS.VirtualFileSystemHook\GVFS.VirtualFileSystemHook.vcxproj" />
2827
<ProjectReference Include="..\GVFS\GVFS.csproj" />
@@ -48,7 +47,6 @@
4847
$(OutputPath)\GVFS.PostIndexChangedHook.exe;
4948
$(OutputPath)\GVFS.ReadObjectHook.exe;
5049
$(OutputPath)\GVFS.Service.exe;
51-
$(OutputPath)\GVFS.Service.UI.exe;
5250
$(OutputPath)\GVFS.VirtualFileSystemHook.exe;
5351
$(OutputPath)\GVFS.Virtualization.dll;">
5452
<Authenticode>Microsoft400</Authenticode>

GVFS/GVFS.Payload/layout.bat

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ xcopy /Y /S %BUILD_OUT%\GVFS\%MANAGED_OUT_FRAGMENT%\* %OUTPUT%
5454
xcopy /Y /S %BUILD_OUT%\GVFS.Hooks\%MANAGED_OUT_FRAGMENT%\* %OUTPUT%
5555
xcopy /Y /S %BUILD_OUT%\GVFS.Mount\%MANAGED_OUT_FRAGMENT%\* %OUTPUT%
5656
xcopy /Y /S %BUILD_OUT%\GVFS.Service\%MANAGED_OUT_FRAGMENT%\* %OUTPUT%
57-
xcopy /Y /S %BUILD_OUT%\GVFS.Service.UI\%MANAGED_OUT_FRAGMENT%\* %OUTPUT%
5857
xcopy /Y /S %BUILD_OUT%\GitHooksLoader\%NATIVE_OUT_FRAGMENT%\* %OUTPUT%
5958
xcopy /Y /S %BUILD_OUT%\GVFS.PostIndexChangedHook\%NATIVE_OUT_FRAGMENT%\* %OUTPUT%
6059
xcopy /Y /S %BUILD_OUT%\GVFS.ReadObjectHook\%NATIVE_OUT_FRAGMENT%\* %OUTPUT%

GVFS/GVFS.Service.UI/Data/ActionItem.cs

Lines changed: 0 additions & 17 deletions
This file was deleted.

GVFS/GVFS.Service.UI/Data/ActionsData.cs

Lines changed: 0 additions & 10 deletions
This file was deleted.

GVFS/GVFS.Service.UI/Data/BindingData.cs

Lines changed: 0 additions & 13 deletions
This file was deleted.

GVFS/GVFS.Service.UI/Data/BindingItem.cs

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)