Merge pull request #967 Fix EventMetadata construction in TryDownloadPrefetchPacks

wilbaker · web-flow · commit d52ce434d21e · 2019-03-26T15:01:14.000-07:00
Fix EventMetadata construction in TryDownloadPrefetchPacks
diff --git a/GVFS/GVFS.Common/Git/GitObjects.cs b/GVFS/GVFS.Common/Git/GitObjects.cs
@@ -151,9 +151,8 @@ public virtual bool TryDownloadPrefetchPacks(GitProcess gitProcess, long latestT
                     }
                     else
                     {
-                        EventMetadata error = CreateEventMetadata();
+                        EventMetadata error = CreateEventMetadata(result.Error);
                         error.Add("latestTimestamp", latestTimestamp);
-                        error.Add("Exception", result.Error);
                         error.Add(nameof(this.GitObjectRequestor.CacheServer.PrefetchEndpointUrl), this.GitObjectRequestor.CacheServer.PrefetchEndpointUrl);
                         activity.RelatedWarning(error, "DownloadPrefetchPacks failed.", Keywords.Telemetry);
                     }

Original file line number	Diff line number	Diff line change
`@@ -151,9 +151,8 @@ public virtual bool TryDownloadPrefetchPacks(GitProcess gitProcess, long latestT`
`151`	`151`	`}`
`152`	`152`	`else`
`153`	`153`	`{`
`154`		`- EventMetadata error = CreateEventMetadata();`
	`154`	`+ EventMetadata error = CreateEventMetadata(result.Error);`
`155`	`155`	`error.Add("latestTimestamp", latestTimestamp);`
`156`		`- error.Add("Exception", result.Error);`
`157`	`156`	`error.Add(nameof(this.GitObjectRequestor.CacheServer.PrefetchEndpointUrl), this.GitObjectRequestor.CacheServer.PrefetchEndpointUrl);`
`158`	`157`	`activity.RelatedWarning(error, "DownloadPrefetchPacks failed.", Keywords.Telemetry);`
`159`	`158`	`}`