Add additional diagnostics to GitStatusAfterRenameFileIntoRepo functional test#1006
Merged
wilbaker merged 1 commit intoApr 4, 2019
Conversation
wilbaker
added
platform: macOS
platform: windows
and removed
platform: macOS
platform: windows
labels
Member
Author
|
/azp run Windows - Full Functional Tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeschu1
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitStatusAfterRenameFileIntoRepo was occasionally failing (see #890 for details).
From the failure report in #890, it was unclear if the failure was due to the move/rename failing, or the rename notification not being delivered to VFS4G.
Changes in this PR:
ShouldNotExistOnDiskwas being called with the wrong path, this has been fixed