Allow mounting on ReFS volumes#1822
Merged
Merged
Conversation
ReFS is the underlying filesystem that dev drives use and should be supported.
dscho
approved these changes
Oct 25, 2024
Member
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
This change looks good to me, and I am just as puzzled why this change was not required before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReFS is the underlying filesystem that Dev Drives use and should be supported.
VFS for Git let ReFS drives through fine under https://github.com/microsoft/VFSForGit/releases/tag/v1.0.24074.1. I'm not sure why the volume check did not error out, but something changed and after installing the latest prereleases, existing enlistments on Dev Drives are now blocked. They should not be.
(git bisect did not find the issue, nor did I expect it to given this code path did not change)