Remove x64 check from installer#1827
Merged
Merged
Conversation
derrickstolee
approved these changes
Dec 3, 2024
tyrielv
force-pushed
the
arm-installer
branch
from
820ebc8 to
c78180e
Compare
mjcheetham
requested changes
Dec 12, 2024
Member
mjcheetham
left a comment
mjcheetham
left a comment
There was a problem hiding this comment.
Looks good, just need to revert the " that got added to the csproj file by Visual Studio. Thanks!
PR microsoft#1815 updated the installer dependency version, which seems to have caused the installer to enforce the AllowedArchitectures=x64 check (which has been there for years). We've received complaints from users that the latest release refuses to install on their ARM machines, but previous versions did and worked fine with the default x86/64 emulation. The latest version of Innosetup adds x64compatible option for the AllowedArchitectures and ArchitecturesInstallIn64BitMode to address the case of x64 emulation on ARM.
tyrielv
force-pushed
the
arm-installer
branch
from
c78180e to
da1637a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1815 updated the installer dependency version, which seems to have caused the installer to enforce the AllowedArchitectures=x64 check (which has been there for years). We've received complaints from users that the latest release refuses to install on their ARM machines, but previous versions did and worked fine with the default x86/64 emulation.
Although ARM is not explicitly supported, we should not prevent users from installing GVFS on ARM when it has been working for them so far.