Skip to content

.NET 10 NativeAOT migration #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrielv merged 8 commits into from
May 4, 2026
Merged

.NET 10 NativeAOT migration #1953

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6633447
Retarget managed projects to .NET 10 with NativeAOT
tyrielv Apr 29, 2026
f2df404
Replace System.Reflection.Assembly usage for NativeAOT
tyrielv Apr 29, 2026
c5b7ca7
Replace changed .NET 10 APIs
tyrielv Apr 29, 2026
bb78760
Replace System.Management WMI with kernel32 P/Invoke
tyrielv Apr 29, 2026
c36bc23
Guard against null triggeringProcessImageFileName from ProjFS
tyrielv Apr 29, 2026
97fa1e1
Replace HTTP stack for .NET 10
tyrielv Apr 29, 2026
33d3b95
Add source-generated JSON serialization for NativeAOT
tyrielv Apr 29, 2026
62c5c6c
Adapt functional tests for .NET 10 ProjFS behavioral changes
tyrielv Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Guard against null triggeringProcessImageFileName from ProjFS 
ProjFS managed API v2.1.0 uses Marshal.PtrToStringUni which returns null
for IntPtr.Zero (kernel operations with PID 0). The old C++/CLI wrapper
returned String.Empty. Null-coalesce to match old behavior in all three
callback sites (OnPlaceholderFileCreated, OnPlaceholderFolderCreated,
OnPlaceholderFileHydrated); ConcurrentDictionary does not accept null keys.

Co-authored-by: Michael Niksa <miniksa@microsoft.com>
Assisted-by: Claude Opus 4.6
Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
  • Loading branch information
@tyrielv @miniksa
tyrielv and miniksa committed May 1, 2026
commit c36bc2376a4c53541f6b270ff225d441dd15a115
10 changes: 7 additions & 3 deletions GVFS/GVFS.Virtualization/FileSystemCallbacks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,8 +695,12 @@ public void OnPlaceholderFileCreated(string relativePath, string sha, string tri
// Note: Because OnPlaceholderFileCreated is not synchronized on all platforms it is possible that GVFS will double count
// the creation of file placeholders if multiple requests for the same file are received at the same time on different
// threads.
//
// triggeringProcessImageFileName can be null when ProjFS reports a triggering process ID of 0 (e.g. kernel or
// system-level operations). The ProjFS managed API may pass null for the image file name in AOT builds.
// ConcurrentDictionary does not allow null keys, so fall back to a sentinel value.
this.filePlaceHolderCreationCount.AddOrUpdate(
triggeringProcessImageFileName,
triggeringProcessImageFileName ?? string.Empty,
(imageName) => { return new PlaceHolderCreateCounter(); },
(key, oldCount) => { oldCount.Increment(); return oldCount; });
}
Expand All @@ -711,7 +715,7 @@ public void OnPlaceholderFolderCreated(string relativePath, string triggeringPro
this.GitIndexProjection.OnPlaceholderFolderCreated(relativePath);

this.folderPlaceHolderCreationCount.AddOrUpdate(
triggeringProcessImageFileName,
triggeringProcessImageFileName ?? string.Empty,
(imageName) => { return new PlaceHolderCreateCounter(); },
(key, oldCount) => { oldCount.Increment(); return oldCount; });
}
Expand All @@ -724,7 +728,7 @@ public void OnPlaceholderFolderExpanded(string relativePath)
public void OnPlaceholderFileHydrated(string triggeringProcessImageFileName)
{
this.fileHydrationCount.AddOrUpdate(
triggeringProcessImageFileName,
triggeringProcessImageFileName ?? string.Empty,
(imageName) => { return new PlaceHolderCreateCounter(); },
(key, oldCount) => { oldCount.Increment(); return oldCount; });
}
Expand Down