Skip to content

Telemetry: Record when a mount succesfully starts #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeschu1 merged 1 commit into from
Nov 1, 2018
Merged

Telemetry: Record when a mount succesfully starts #437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions GVFS/GVFS.Mount/InProcessMount.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,15 @@ public void Mount(EventLevel verbosity, Keywords keywords)
Console.Title = "GVFS " + ProcessHelper.GetCurrentProcessVersion() + " - " + this.enlistment.EnlistmentRoot;

this.tracer.RelatedEvent(
EventLevel.Critical,
EventLevel.Informational,
"Mount",
new EventMetadata
{
// Use TracingConstants.MessageKey.InfoMessage rather than TracingConstants.MessageKey.CriticalMessage
// as this message should not appear as an error
{ TracingConstants.MessageKey.InfoMessage, "Virtual repo is ready" },
});
},
Keywords.Telemetry);
Copy link
Copy Markdown
Member

@wilbaker wilbaker Oct 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be EventLevel.Critical, or can we make this Info level (see line 137)?

CC: @sanoursa. Saeed, do you remember if we perviously got push back for Critical + Telemetry events?

Copy link
Copy Markdown
Member

@wilbaker wilbaker Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed this with @sanoursa offline and he agreed this should no longer be Critical.

Copy link
Copy Markdown
Member Author

@jeschu1 jeschu1 Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wilbaker , I updated as suggested


this.currentState = MountState.Ready;

Expand Down