Skip to content

Start the move to yaml pipelines.#540

Merged
jrbriggs merged 3 commits into
microsoft:masterfrom
jrbriggs:yaml-build
Dec 10, 2018
Merged

Start the move to yaml pipelines.#540
jrbriggs merged 3 commits into
microsoft:masterfrom
jrbriggs:yaml-build

Conversation

@jrbriggs
Copy link
Copy Markdown
Member

It's better to have the pipeline config in code, so let's move to yaml.

Comment thread .azure-pipelines/templates/windows-functional-test.yml Outdated
Comment thread .azure-pipelines/templates/windows-functional-test.yml Outdated
Copy link
Copy Markdown
Contributor

@sanoursa sanoursa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any pipelines that are using these new yaml files? Everything seems fine, but I have no way to test or validate any of it

Comment thread .azure-pipelines/continuous-integration.yml Outdated
Comment thread .azure-pipelines/continuous-integration.yml Outdated
Comment thread .azure-pipelines/pull-request.yml
Comment thread .azure-pipelines/templates/windows-build-and-unit-test.yml Outdated
Comment thread GVFS/GVFS.Build/GenerateUnifiedInstallScript.cs Outdated
Comment thread Scripts/RunFunctionalTests.bat Outdated
Comment thread .azure-pipelines/continuous-integration.yml Outdated
Copy link
Copy Markdown
Member

@kewillford kewillford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions to understand this better.

Comment thread .azure-pipelines/continuous-integration.yml Outdated
Comment thread .azure-pipelines/continuous-integration.yml Outdated
Comment thread .azure-pipelines/pull-request.yml Outdated
Comment thread .azure-pipelines/templates/windows-build-and-unit-test.yml
Comment thread .azure-pipelines/templates/windows-functional-test.yml
Comment thread .azure-pipelines/templates/windows-functional-test.yml Outdated
Comment thread .azure-pipelines/templates/windows-functional-test.yml Outdated
Comment thread Scripts/CI/CreateBuildDrop.bat
@jrbriggs
Copy link
Copy Markdown
Member Author

jrbriggs commented Nov 21, 2018

@sanoursa said:

Do you have any pipelines that are using these new yaml files? Everything seems fine, but I have no way to test or validate any of it

Yep: https://dev.azure.com/gvfs/ci/_build/results?buildId=4061&view=logs

@jrbriggs
Copy link
Copy Markdown
Member Author

Ignore the failed check. I can't authorize access to the secret file without having the yaml out of my fork and into Microsoft/VFSForGit. Once I do, the checks should come online too.

@jrbriggs jrbriggs requested a review from vtbassmatt November 21, 2018 02:02
Comment thread .azure-pipelines/continuous-integration.yml
Comment thread .azure-pipelines/pull-request.yml
@jrbriggs
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member

@kewillford kewillford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you verified that this is updating the github status?

@jrbriggs
Copy link
Copy Markdown
Member Author

@kewillford to set up the pipeline to post status, i first have to get the yaml file into the branch, as best as i can tell, because i need to authorize access to the secure file we have in the pipeline. Getting it all configured to post statuses will be my next PR. Thanks for the review!

@jrbriggs jrbriggs merged commit e187094 into microsoft:master Dec 10, 2018
@jrbriggs jrbriggs added this to the S147 milestone Feb 7, 2019
@jrbriggs jrbriggs added the affects: engineering Keeping the engineering system healthy label Feb 8, 2019
@jrbriggs jrbriggs deleted the yaml-build branch February 9, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects: engineering Keeping the engineering system healthy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants