Mac: Kill any git/gvfs processes when cleaning up after Functional Tests#567
Merged
Merged
Conversation
sanoursa
reviewed
Nov 30, 2018
| . "$(dirname ${BASH_SOURCE[0]})/InitializeEnvironment.sh" | ||
|
|
||
| pkill -l git | ||
| pkill -l gvfs |
Contributor
There was a problem hiding this comment.
Will this also take down gvfs.mount?
Contributor
There was a problem hiding this comment.
We should probably also kill the prjfs-log tool unless that's already handled elsewhere.
Member
Author
There was a problem hiding this comment.
This will take down gvfs.mount as well as it matches substrings per the man page for pkill. I've validated this locally and confirmed that the PIDs that were killed match both 'gvfs' and 'gvfs.mount' processes that were running.
Thanks for catching prjfs-log!
…l tests run as we do on Windows
nickgra
force-pushed
the
pkillFunctionalTests
branch
from
5a16064 to
46c9ca6
Compare
pmj
approved these changes
Dec 1, 2018
Contributor
pmj
left a comment
pmj
left a comment
There was a problem hiding this comment.
Looks sensible enough to me!
jeschu1
approved these changes
Dec 3, 2018
Member
|
Thanks for looking into this @nickgra! |
wilbaker
approved these changes
Dec 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, a developer might make a change that causes the functional tests to hang or take an extremely long time. The job will time out after 120 minutes and we don't currently clean up any processes that could still be running. We should pkill any git/gvfs processes still running while we're cleaning up.
This is similar to what we're doing in UnInstallGVFS.bat on Windows.