Allow --files-list option for prefetch#588
Conversation
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I think the command-line options need some tweaks, and a lot of style/small fixes in the implementation.
|
As per @derrickstolee suggestions, added separate flags to trigger file or folder list loading from stdin |
|
Fixed the build issue, by adding the stdin option to fastfetch as well. |
turbonaitis
force-pushed
the
fetchFilesFromList
branch
from
89cfd0a to
3e1c8d5
Compare
|
@turbonaitis Please leave FastFetch alone. That's kind of a separate project and should not be taken into account just for consistency-sake. |
|
@derrickstolee removed. Out of interest, why do you want to prevent new features from being added to FastFetch? |
|
@turbonaitis The fact that FastFetch lives in the VFS for Git codebase is a bit of a historical oddity. The projects try to do very different things. VFS for Git wants to virtualize an repository, only hydrating files on-demand. FastFetch wants to hydrate an entire enlistment as fast as it possibly can. The only reason it's here is because it depends on the /gvfs/objects endpoint. In the future, I see FastFetch lifting out of the VFS for Git repository. /cc @derrickstolee |
I understand, that it's a separate tool with a different purpose, but I fail to understand, how adding features to it is a bad thing. In any case, it's your decision - I've updated my PR to not include changes to FastFetch. |
|
@derrickstolee are there any more outstanding changes for this PR? |
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
I just found a few style things at this point.
@wilbaker do you mind taking a look? Most of the low-hanging comments should be covered.
No problem, taking a look now |
wilbaker
left a comment
wilbaker
left a comment
There was a problem hiding this comment.
Overall the changes are looking good, I've left some comments (mostly minor).
wilbaker
left a comment
wilbaker
left a comment
There was a problem hiding this comment.
Looks good, I've kicked off the Mac functional tests for this PR
|
@wilbaker merged in changes from master to prevent merge conflicts. |
|
Thanks, @turbonaitis! |
|
Thanks for your comments! |
4 participants
This PR addresses #580 and adds --files-list option to prefetch verb. It also adds a magic file name, to allow passing in both --files-list and --folders-list via stdin.