Stop reading ring info from Nuget feedurl#787
Merged
Conversation
Reverting commit c4af872. Service will only use ring info specified in upgrade.ring config setting. Service will not use ring info specified in nuget feed url. Also removed the associated UT cases.
jamill
approved these changes
Feb 13, 2019
Member
|
@alameenshah @jamill do we need to make any changes in how we decide if the nuget upgrader is configured? The |
Contributor
Author
No changes needed. |
Member
|
I validated this works as expected as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting commit c4af872.
Service will only use ring info specified in upgrade.ring config setting. Service will not use ring info specified in nuget feed url (even if it contains one.) Also removed the associated UT cases.