[cherry-pick to master] Use a new log directory for upgrade logs to avoid ACL issues#843
Merged
wilbaker merged 1 commit intoFeb 25, 2019
Conversation
ownership. In previous versions of VFS4G `gvfs upgrade` could create directories with regular users as owners, and this ownership setting left GVFS.Service unable to update the ACLs on the directory. Rather trying to take ownership of the old logs directory and update the ACLs, this commit updates VFS4G to using a new directory (`UpgraderLogs`) that is explicitly created with the correct ACLs. Old log files will not be migrated to the new folder.
wilbaker
force-pushed
the
new_upgrade_log_directory_port_to_master
branch
from
920567e to
04c4b93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of the changes in #840 to master
Fixes #837
This address the issue in #837 by switching to a new directory for upgrader logs. GVFS.Service will create the directory if it does not exist (with the proper ACLs) and prevent the directory from inheriting ACLs (when GVFS.Service updates them on C:\ProgramData\GVFS).
Additionally,
gvfs upgradewill use the correct ACLs when creating the logs directory if for some reason the service has not already created it.Note: There is no automatic healing if someone manually adjusts the ACLs on the directory.