[upgrade] Upgrade Functional Test failure fix#905
Merged
Conversation
alameenshah
added
the
type: test-reliability
wilbaker
reviewed
Mar 8, 2019
wilbaker
approved these changes
Mar 8, 2019
When Nuget settings (upgrade.feedurl & upgrade.feedpackagename) are not available in gvfs config, then an attempt to read (or write) those missing values will cause gvfs config read/write to exit with error code 3. This will cause UpgradeReminder FT to fail on PCs where Nuget is not configured. Fixes #852
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Nuget settings (
upgrade.feedurl&upgrade.feedpackagename) are not available ingvfs config, then an attempt to read (or write) those missing values will causegvfs config read/writeto exit with error code3.UpgradeReminderFT tries to 1. read existing nuget config, 2. delete it, 3. execute tests and then 4. restore previously read Nuget config. The failure used to happen in step 1. while attempting to read a config key which is not available ingvfs configfile.Fixes #852