Fix EventMetadata construction in TryDownloadPrefetchPacks#967
Merged
wilbaker merged 1 commit intoMar 26, 2019
Merged
Conversation
wilbaker
added
type: bug
platform: macOS
platform: windows
priority: dogfood
nickgra
approved these changes
Mar 26, 2019
Member
nickgra
left a comment
nickgra
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the speedy turnaround! Should we open a work item to put up a guard rail to prevent programmers from making this mistake again?
Member
Author
Filed #968 for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #960
TryDownloadPrefetchPackswas not callingToStringon the exception it was adding to theEventMetadata. Rather that callingToStringthe code has been updated to pass the exception toCreateEventMetadatawhich will do the right thing.