Skip to content

use "which" to locate git installation #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilbaker merged 2 commits into from
Apr 10, 2019
Merged

use "which" to locate git installation #999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
567c11b
use "where" to locate git installation
kivikakk Apr 3, 2019
791459c
remove unit test
kivikakk Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions GVFS/GVFS.Platform.POSIX/POSIXGitInstallation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using GVFS.Common.Git;
using GVFS.Common;
using GVFS.Common.Git;
using System.IO;

namespace GVFS.Platform.POSIX
Expand All @@ -19,14 +20,13 @@ public bool GitExists(string gitBinPath)

public string GetInstalledGitBinPath()
{
// TODO(POSIX): Use 'which' to find git (like the Windows platform uses "where")
string gitBinPath = $"/usr/local/bin/{GitProcessName}";
if (File.Exists(gitBinPath))
ProcessResult result = ProcessHelper.Run("which", args: "git", redirectOutput: true);
if (result.ExitCode != 0)
{
return gitBinPath;
return null;
}

return null;
return result.Output.Trim();
}
}
}