Potential fix for pull request finding 'Inefficient use of ContainsKey'

imran-siddique · github-code-quality[bot] · imran-siddique · commit a49ce6cf34b4 · 2026-05-07T16:27:08.000-07:00
Co-authored-by: Copilot Autofix powered by AI &lt;223894421+github-code-quality[bot]@users.noreply.github.com&gt;
Signed-off-by: Imran Siddique &lt;imran.siddique@microsoft.com&gt;
diff --git a/agent-governance-dotnet/examples/AspNetMiddleware/Controllers/ItemsController.cs b/agent-governance-dotnet/examples/AspNetMiddleware/Controllers/ItemsController.cs
@@ -70,12 +70,12 @@ public static ActionResult<Item> Update(int id, [FromBody] UpdateItemRequest req
     {
         lock (Sync)
         {
-            if (!Store.ContainsKey(id))
+            if (!Store.TryGetValue(id, out var existing))
             {
                 return NotFound();
             }
 
-            var updated = new Item(id, request.Name ?? Store[id].Name);
+            var updated = new Item(id, request.Name ?? existing.Name);
             Store[id] = updated;
             return Ok(updated);
         }

Original file line number	Diff line number	Diff line change
`@@ -70,12 +70,12 @@ public static ActionResult<Item> Update(int id, [FromBody] UpdateItemRequest req`
`70`	`70`	`{`
`71`	`71`	`lock (Sync)`
`72`	`72`	`{`
`73`		`- if (!Store.ContainsKey(id))`
	`73`	`+ if (!Store.TryGetValue(id, out var existing))`
`74`	`74`	`{`
`75`	`75`	`return NotFound();`
`76`	`76`	`}`
`77`	`77`
`78`		`- var updated = new Item(id, request.Name ?? Store[id].Name);`
	`78`	`+ var updated = new Item(id, request.Name ?? existing.Name);`
`79`	`79`	`Store[id] = updated;`
`80`	`80`	`return Ok(updated);`
`81`	`81`	`}`