fix: ensure utf-8 encoding is used in all relevant open() calls#7198
Open
jackjin1997 wants to merge 4 commits intomicrosoft:mainfrom
Open
fix: ensure utf-8 encoding is used in all relevant open() calls#7198jackjin1997 wants to merge 4 commits intomicrosoft:mainfrom
jackjin1997 wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
jackjin1997
force-pushed
the
fix/utf8-encoding-global
branch
from
7c891a0 to
3b0732f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses potential
UnicodeDecodeErrorin non-English environments (e.g., Windows with different code pages) by ensuring thatencoding='utf-8'is explicitly specified in all relevantopen()calls.While the specific issue in
playwright_controller.pymentioned in #5566 appears to be fixed in the latest version, this PR proactively fixes similar patterns in:magentic-one-cliautogen-ext(experimental memory recorder and docker jupyter executor)These changes ensure consistent behavior across different platforms and locales.
Fixes #5566