Conversation
The checking of variadic functions in checked scope follows these rules: 1. All warnings issued by the -Wformat family of flags are errors in checked scope. 2. No bounds checking of arguments to variadic functions like printf/scanf, etc is done. For printf-like functions: 3. %s is allowed only with arg type _Nt_array_ptr or _Nt_checked. 4. %p is allowed with any arg type. 5. %n is disallowed. 6. For all other format specifiers, only scalar arg types are allowed. For scanf-like functions: 7. %s is disallowed. 8. All width modifiers to format specifiers are disallowed. 9. %p is disallowed 10. %n is disallowed 11. For all other format specifiers, only _Ptr arg types are allowed.
Member
|
It looks like this PR closes off all the safety holes in #1178 except |
Co-authored-by: Matt McCutchen (Correct Computation) <matt@correctcomputation.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checking of variadic functions in checked scope follows these rules:
scope.
etc is done.
For printf-like functions:
3. %s is allowed only with arg type _Nt_array_ptr or _Nt_checked.
4. %p is allowed with any arg type.
5. %n is disallowed.
6. For all other format specifiers, only scalar arg types are allowed.
For scanf-like functions:
7. %s is disallowed.
8. All width modifiers to format specifiers are disallowed.
9. %p is disallowed
10. %n is disallowed
11. For all other format specifiers, only _Ptr arg types are allowed.