Skip to content

Reset killed bounds for in-scope variables only #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2020
Merged

Reset killed bounds for in-scope variables only #926

merged 2 commits into from
Oct 23, 2020

Conversation

kkjeer
Copy link
Contributor

@kkjeer kkjeer commented Oct 22, 2020

Fixes #925

This PR adjusts ResetKilledBounds to only reset a variable v whose widened bounds have been killed by statement S if v is in scope at S, i.e. if v is already present in State.ObservedBounds.

Testing:

  • Added a function to widened-bounds.c to test this change.
  • Passed automated testing on Linux.

@kkjeer kkjeer requested review from dtarditi and mgrang October 22, 2020 23:30
mgrang
mgrang approved these changes Oct 23, 2020
View reviewed changes
Copy link

@mgrang mgrang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kkjeer kkjeer merged commit bc944f9 into master Oct 23, 2020
@kkjeer kkjeer deleted the issue-925-resetkilledbounds branch October 23, 2020 03:33
@secure-sw-dev-bot secure-sw-dev-bot mentioned this pull request Jan 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrang mgrang mgrang approved these changes

@dtarditi dtarditi Awaiting requested review from dtarditi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResetKilledBounds adds out-of-scope variables to bounds context
2 participants
@kkjeer @mgrang