Skip to content

Commit 2b1ac67

Browse files
committed
PR comment nits
1 parent 1088716 commit 2b1ac67

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/Microsoft.ComponentDetection.Detectors/npm/NpmComponentDetector.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ protected override async Task OnFileFoundAsync(ProcessRequest processRequest, ID
5252
var packageJson = await JsonSerializer.DeserializeAsync<PackageJson>(file.Stream, JsonOptions, cancellationToken);
5353
if (packageJson is null)
5454
{
55-
this.Logger.LogInformation("Could not deserialize {PackageJsonFile}.", filePath);
55+
this.Logger.LogInformation("Could not deserialize {PackageJsonFile}", filePath);
5656
return;
5757
}
5858

@@ -66,7 +66,7 @@ protected override async Task OnFileFoundAsync(ProcessRequest processRequest, ID
6666
}
6767
catch (JsonException e)
6868
{
69-
this.Logger.LogInformation(e, "Could not parse JSON from file {PackageJsonFilePaths}.", filePath);
69+
this.Logger.LogInformation(e, "Could not parse JSON from file {PackageJsonFilePaths}", filePath);
7070
}
7171
}
7272

@@ -82,6 +82,8 @@ protected virtual bool ProcessPackageJson(string filePath, ISingleFileComponentR
8282
return false;
8383
}
8484

85+
// Check for VS Code extensions
86+
// See https://code.visualstudio.com/api/working-with-extensions/publishing-extension#visual-studio-code-compatibility
8587
var containsVsCodeEngine = false;
8688
if (packageJson.Engines is not null && packageJson.Engines.ContainsKey("vscode"))
8789
{

0 commit comments

Comments
 (0)