Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Stardust is unconsumable for TS client project with no --skipLibCheck flag #276

Closed
kuzhelov opened this issue Sep 25, 2018 · 2 comments · Fixed by #367
Closed

Stardust is unconsumable for TS client project with no --skipLibCheck flag #276

kuzhelov opened this issue Sep 25, 2018 · 2 comments · Fixed by #367
Labels
vsts Paired with ticket in vsts

Comments

@kuzhelov
Copy link
Contributor

Bug Report

Steps

  • create test app project: create-react-app --scripts-version=react-scripts-ts
  • add Stardust as a dependency: yarn add @stardust-ui/react
  • reference some components from Stardust in App.tsx
  • try to build the project

Expected Result

Project builds successfully.

Actual Result

Project fails to build 💣

Version

0.6.0

@kuzhelov
Copy link
Contributor Author

kuzhelov commented Sep 25, 2018

According to preliminary debugging takeaways:

  • this problem is caused by compiler providing shorthand paths instead of relative ones for Stardust .d.ts files (when Stardust package is built prior to its publishing)
  • our ad-hoc gulp plugin (that is aimed to substitute shortcut paths with relative ones) currently targets only the paths that start from src (this was done intentionally at initial stages, when we've seen this problem for src only).

We might tweak gulp plugin's behavior to address broader set of path issues (actually, just tweak config), also might try to play with TS config.

@levithomason
Copy link
Member

Noting this is present in the latest 0.7.0 as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vsts Paired with ticket in vsts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants