chore: improve docgen perf #14590
Merged
chore: improve docgen perf #14590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
layershifter
commented
Aug 18, 2020
dzearing
reviewed
Aug 18, 2020
|
I think @ecraig12345 should probably take a look here as well, seems reasonable. |
dzearing
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Seems reasonable, but @ecraig12345 might be able to spot something better here.
This is definitely better, but it still awful 😨 I don't have the explanation why it slow downs on some files. @ecraig12345 any ideas?
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a4a4ea6b7c60bdf605bbc884b37120590050f79c (build) |
ecraig12345
reviewed
Aug 18, 2020
Co-authored-by: Elizabeth Craig <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9262503:
|
…ntui into chore/docgen-perf
This change was reverted as we have circular references in our code 😭 |
pompomon
approved these changes
Aug 20, 2020
layershifter
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is heavily based on work that @ecraig12345 did in #12897. However, the actual implementation is inspired by strothj/react-docgen-typescript-loader#40. The idea is still the same - to reuse the same
ts.Programas it's quite heavy. Direct requires of component's files were also removes to parsedefaultPropswe reuse existing AST produced by Babel.This allows to speed up
build:component-infowithout caching it takes around 100-110 seconds on machine.Previous PRs:
Finished 'build:docs:assets:component:info' after 5.35 minThis PR:
Finished 'build:docs:assets:component:info' after 1.57 minAnother change is the lazy evaluation for@babel/plugin-transform-modules-commonjs. This improves initial load time of modules because dependencies will be evaluated based on their usage.