Revert "trace2: create new combined trace facility"

This reverts commit 1354d73.

Author: jeffhostetler

Makefile

@@ -1000,15 +1000,6 @@ LIB_OBJS += tempfile.o
 LIB_OBJS += thread-utils.o
 LIB_OBJS += tmp-objdir.o
 LIB_OBJS += trace.o
-LIB_OBJS += trace2.o
-LIB_OBJS += trace2/tr2_cfg.o
-LIB_OBJS += trace2/tr2_dst.o
-LIB_OBJS += trace2/tr2_sid.o
-LIB_OBJS += trace2/tr2_tbuf.o
-LIB_OBJS += trace2/tr2_tgt_event.o
-LIB_OBJS += trace2/tr2_tgt_normal.o
-LIB_OBJS += trace2/tr2_tgt_perf.o
-LIB_OBJS += trace2/tr2_tls.o
 LIB_OBJS += trailer.o
 LIB_OBJS += transport.o
 LIB_OBJS += transport-helper.o

cache.h

@@ -9,7 +9,6 @@
 #include "gettext.h"
 #include "convert.h"
 #include "trace.h"
-#include "trace2.h"
 #include "string-list.h"
 #include "pack-revindex.h"
 #include "hash.h"

common-main.c

@@ -31,9 +31,6 @@ int main(int argc, const char **argv)
 	 * onto stdin/stdout/stderr in the child processes we spawn.
 	 */
 	sanitize_stdfds();
-	restore_sigpipe_to_default();
-
-	trace2_initialize(argv);
 
 	git_resolve_executable_dir(argv[0]);
 
@@ -43,5 +40,7 @@ int main(int argc, const char **argv)
 
 	attr_start();
 
+	restore_sigpipe_to_default();
+
 	return cmd_main(argc, argv);
 }

compat/mingw.c

@@ -1959,7 +1959,6 @@ static int try_shell_exec(const char *cmd, char *const *argv)
 			int status;
 			if (waitpid(pid, &status, 0) < 0)
 				status = 255;
-			trace2_exec_result(status);
 			exit(status);
 		}
 		pid = 1;	/* indicate that we tried but failed */
@@ -1980,7 +1979,6 @@ int mingw_execv(const char *cmd, char *const *argv)
 			return -1;
 		if (waitpid(pid, &status, 0) < 0)
 			status = 255;
-		trace2_exec_result(status);
 		exit(status);
 	}
 	return -1;

compat/mingw.h

@@ -165,7 +165,8 @@ static inline int fcntl(int fd, int cmd, ...)
 	errno = EINVAL;
 	return -1;
 }
-
+/* bash cannot reliably detect negative return codes as failure */
+#define exit(code) exit((code) & 0xff)
 #define sigemptyset(x) (void)0
 static inline int sigaddset(sigset_t *set, int signum)
 { return 0; }

config.c

@@ -2709,8 +2709,6 @@ int git_config_set_gently(const char *key, const char *value)
 void git_config_set(const char *key, const char *value)
 {
 	git_config_set_multivar(key, value, NULL, 0);
-
-	trace2_cmd_set_config(key, value);
 }
 
 /*

exec-cmd.c

@@ -209,8 +209,6 @@ static int git_get_exec_path(struct strbuf *buf, const char *argv0)
 		return -1;
 	}
 
-	trace2_cmd_path(buf->buf);
-
 	return 0;
 }
 
@@ -330,22 +328,16 @@ const char **prepare_git_cmd(struct argv_array *out, const char **argv)
 int execv_git_cmd(const char **argv)
 {
 	struct argv_array nargv = ARGV_ARRAY_INIT;
-	int err;
 
 	prepare_git_cmd(&nargv, argv);
 	trace_argv_printf(nargv.argv, "trace: exec:");
-	trace2_exec("git", (const char **)nargv.argv);
 
 	/* execvp() can only ever return if it fails */
 	sane_execvp("git", (char **)nargv.argv);
 
-	err = errno;
-	trace_printf("trace: exec failed: %s\n", strerror(err));
-	trace2_exec_result(err);
+	trace_printf("trace: exec failed: %s\n", strerror(errno));
 
 	argv_array_clear(&nargv);
-
-	errno = err;
 	return -1;
 }
 

git-compat-util.h

@@ -1291,13 +1291,6 @@ struct fscache;
 
 extern int cmd_main(int, const char **);
 
-/*
- * Intercept all calls to exit() and route them to trace2 to
- * optionally emit a message before calling the real exit().
- */
-int trace2_cmd_exit_fl(const char *file, int line, int code);
-#define exit(code) exit(trace2_cmd_exit_fl(__FILE__, __LINE__, (code)))
-
 /*
  * You can mark a stack variable with UNLEAK(var) to avoid it being
  * reported as a leak by tools like LSAN or valgrind. The argument

git.c

@@ -149,20 +149,16 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
 				git_set_exec_path(cmd + 1);
 			else {
 				puts(git_exec_path());
-				trace2_cmd_verb("_query_");
 				exit(0);
 			}
 		} else if (!strcmp(cmd, "--html-path")) {
 			puts(system_path(GIT_HTML_PATH));
-			trace2_cmd_verb("_query_");
 			exit(0);
 		} else if (!strcmp(cmd, "--man-path")) {
 			puts(system_path(GIT_MAN_PATH));
-			trace2_cmd_verb("_query_");
 			exit(0);
 		} else if (!strcmp(cmd, "--info-path")) {
 			puts(system_path(GIT_INFO_PATH));
-			trace2_cmd_verb("_query_");
 			exit(0);
 		} else if (!strcmp(cmd, "-p") || !strcmp(cmd, "--paginate")) {
 			use_pager = 1;
@@ -291,7 +287,6 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
 			(*argv)++;
 			(*argc)--;
 		} else if (skip_prefix(cmd, "--list-cmds=", &cmd)) {
-			trace2_cmd_verb("_query_");
 			if (!strcmp(cmd, "parseopt")) {
 				struct string_list list = STRING_LIST_INIT_DUP;
 				int i;
@@ -339,14 +334,9 @@ static int handle_alias(int *argcp, const char ***argv)
 			commit_pager_choice();
 
 			child.use_shell = 1;
-			child.trace2_child_class = "shell_alias";
 			argv_array_push(&child.args, alias_string + 1);
 			argv_array_pushv(&child.args, (*argv) + 1);
 
-			trace2_cmd_alias(alias_command, child.args.argv);
-			trace2_cmd_list_config();
-			trace2_cmd_verb("_run_shell_alias_");
-
 			ret = run_command(&child);
 			if (ret >= 0)   /* normal exit */
 				exit(ret);
@@ -381,9 +371,6 @@ static int handle_alias(int *argcp, const char ***argv)
 		/* insert after command name */
 		memcpy(new_argv + count, *argv + 1, sizeof(char *) * *argcp);
 
-		trace2_cmd_alias(alias_command, new_argv);
-		trace2_cmd_list_config();
-
 		*argv = new_argv;
 		*argcp += count - 1;
 
@@ -496,8 +483,6 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
 		die("pre-command hook aborted command");
 
 	trace_argv_printf(argv, "trace: built-in: git");
-	trace2_cmd_verb(p->cmd);
-	trace2_cmd_list_config();
 
 	validate_cache_entries(&the_index);
 	exit_code = status = p->fn(argc, argv, prefix);
@@ -755,34 +740,23 @@ static void execv_dashed_external(const char **argv)
 	cmd.clean_on_exit = 1;
 	cmd.wait_after_clean = 1;
 	cmd.silent_exec_failure = 1;
-	cmd.trace2_child_class = "dashed";
 
 	if (run_pre_command_hook(cmd.args.argv))
 		die("pre-command hook aborted command");
 
 	trace_argv_printf(cmd.args.argv, "trace: exec:");
-	trace2_exec(NULL, cmd.args.argv);
 
 	/*
 	 * If we fail because the command is not found, it is
 	 * OK to return. Otherwise, we just pass along the status code,
 	 * or our usual generic code if we were not even able to exec
 	 * the program.
-	 *
-	 * If the child process ran and we are now going to exit, emit a
-	 * generic string as our trace2 command verb to indicate that we
-	 * launched a dashed command.
 	 */
 	exit_code = status = run_command(&cmd);
-	trace2_exec_result(status);
-	if (status >= 0) {
-		trace2_cmd_verb("_run_dashed_");
+	if (status >= 0)
 		exit(status);
-	}
-	else if (errno != ENOENT) {
-		trace2_cmd_verb("_run_dashed_");
+	else if (errno != ENOENT)
 		exit(128);
-	}
 
 	run_post_command_hook();
 }
@@ -809,15 +783,6 @@ static int run_argv(int *argcp, const char ***argv)
 			struct argv_array args = ARGV_ARRAY_INIT;
 			int i;
 
-			/*
-			 * The current process is committed to launching a
-			 * child process to run the command named in (**argv)
-			 * and exiting.  Log a generic string as the trace2
-			 * command verb to indicate this.  Note that the child
-			 * process will log the actual verb when it runs.
-			 */
-			trace2_cmd_verb("_run_git_alias_");
-
 			if (get_super_prefix())
 				die("%s doesn't support --super-prefix", **argv);
 
@@ -833,8 +798,8 @@ static int run_argv(int *argcp, const char ***argv)
 			 * if we fail because the command is not found, it is
 			 * OK to return. Otherwise, we just pass along the status code.
 			 */
-			i = run_command_v_opt_tr2(args.argv, RUN_SILENT_EXEC_FAILURE |
-						  RUN_CLEAN_ON_EXIT, "git_alias");
+			i = run_command_v_opt(args.argv, RUN_SILENT_EXEC_FAILURE |
+					      RUN_CLEAN_ON_EXIT);
 			if (i >= 0 || errno != ENOENT)
 				exit(i);
 			die("could not execute builtin %s", **argv);
@@ -965,5 +930,5 @@ int cmd_main(int argc, const char **argv)
 	fprintf(stderr, _("failed to run command '%s': %s\n"),
 		cmd, strerror(errno));
 
-	return trace2_cmd_exit(1);
+	return 1;
 }

remote-curl.c

@@ -1340,13 +1340,6 @@ int cmd_main(int argc, const char **argv)
 	string_list_init(&options.deepen_not, 1);
 	string_list_init(&options.push_options, 1);
 
-	/*
-	 * Just report "remote-curl" here (folding all the various aliases
-	 * ("git-remote-http", "git-remote-https", and etc.) here since they
-	 * are all just copies of the same actual executable.
-	 */
-	trace2_cmd_verb("remote-curl");
-
 	remote = remote_get(argv[1]);
 
 	if (argc > 2) {

repository.c

@@ -113,8 +113,6 @@ static int repo_init_gitdir(struct repository *repo, const char *gitdir)
 void repo_set_worktree(struct repository *repo, const char *path)
 {
 	repo->worktree = real_pathdup(path, 1);
-
-	trace2_def_repo(repo);
 }
 
 static int read_and_verify_repository_format(struct repository_format *format,

repository.h

@@ -90,9 +90,6 @@ struct repository {
 	/* Repository's current hash algorithm, as serialized on disk. */
 	const struct git_hash_algo *hash_algo;
 
-	/* A unique-id for tracing purposes. */
-	int trace2_repo_id;
-
 	/* Configurations */
 
 	/* Indicate if a repository has a different 'commondir' from 'gitdir' */

run-command.c

@@ -713,7 +713,6 @@ int start_command(struct child_process *cmd)
 		cmd->err = fderr[0];
 	}
 
-	trace2_child_start(cmd);
 	trace_run_command(cmd);
 
 	fflush(NULL);
@@ -928,8 +927,6 @@ int start_command(struct child_process *cmd)
 #endif
 
 	if (cmd->pid < 0) {
-		trace2_child_exit(cmd, -1);
-
 		if (need_in)
 			close_pair(fdin);
 		else if (cmd->in)
@@ -968,16 +965,13 @@ int start_command(struct child_process *cmd)
 int finish_command(struct child_process *cmd)
 {
 	int ret = wait_or_whine(cmd->pid, cmd->argv[0], 0);
-	trace2_child_exit(cmd, ret);
 	child_process_clear(cmd);
 	return ret;
 }
 
 int finish_command_in_signal(struct child_process *cmd)
 {
-	int ret = wait_or_whine(cmd->pid, cmd->argv[0], 1);
-	trace2_child_exit(cmd, ret);
-	return ret;
+	return wait_or_whine(cmd->pid, cmd->argv[0], 1);
 }
 
 
@@ -999,18 +993,7 @@ int run_command_v_opt(const char **argv, int opt)
 	return run_command_v_opt_cd_env(argv, opt, NULL, NULL);
 }
 
-int run_command_v_opt_tr2(const char **argv, int opt, const char *tr2_class)
-{
-	return run_command_v_opt_cd_env_tr2(argv, opt, NULL, NULL, tr2_class);
-}
-
 int run_command_v_opt_cd_env(const char **argv, int opt, const char *dir, const char *const *env)
-{
-	return run_command_v_opt_cd_env_tr2(argv, opt, dir, env, NULL);
-}
-
-int run_command_v_opt_cd_env_tr2(const char **argv, int opt, const char *dir, const char *const *env,
-				 const char *tr2_class)
 {
 	struct child_process cmd = CHILD_PROCESS_INIT;
 	cmd.argv = argv;
@@ -1022,7 +1005,6 @@ int run_command_v_opt_cd_env_tr2(const char **argv, int opt, const char *dir, co
 	cmd.clean_on_exit = opt & RUN_CLEAN_ON_EXIT ? 1 : 0;
 	cmd.dir = dir;
 	cmd.env = env;
-	cmd.trace2_child_class = tr2_class;
 	return run_command(&cmd);
 }
 
@@ -1866,15 +1848,6 @@ int run_processes_parallel(int n,
 	int output_timeout = 100;
 	int spawn_cap = 4;
 	struct parallel_processes pp;
-	/*
-	 * TODO Currently all callers of run_processes_parallel()
-	 * are in the submodule code, so hard-coding the category
-	 * is OK for now.  Later, pass in category to this function.
-	 */
-	const char *category = "submodule";
-
-	trace2_region_enter_printf(category, "run_pp", NULL,
-				   "max:%d", ((n < 1) ? online_cpus() : n));
 
 	pp_init(&pp, n, get_next_task, start_failure, task_finished, pp_cb);
 	while (1) {
@@ -1904,8 +1877,5 @@ int run_processes_parallel(int n,
 	}
 
 	pp_cleanup(&pp);
-
-	trace2_region_leave(category, "run_pp", NULL);
-
 	return 0;
 }