Skip to content

Commit 9c4ea1a

Browse files
dschoderrickstolee
authored andcommitted
Merge virtualfilesystem hook
Add virtual file system settings and hook proc. On index load, clear/set the skip worktree bits based on the virtual file system data. Use virtual file system data to update skip-worktree bit in unpack-trees. Use virtual file system data to exclude files and folders not explicitly requested. The hook was first contributed in private, but was extended via the following pull requests: #15 #27 #33 #70 Signed-off-by: Ben Peart <[email protected]> Signed-off-by: Derrick Stolee <[email protected]>
2 parents 6cf43ec + 340a872 commit 9c4ea1a

15 files changed

+852
-4
lines changed

Documentation/config/core.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,14 @@ core.fsmonitorHookVersion::
7979
something that can be used to determine what files have changed
8080
without race conditions.
8181

82+
core.virtualFilesystem::
83+
If set, the value of this variable is used as a command which
84+
will identify all files and directories that are present in
85+
the working directory. Git will only track and update files
86+
listed in the virtual file system. Using the virtual file system
87+
will supersede the sparse-checkout settings which will be ignored.
88+
See the "virtual file system" section of linkgit:githooks[5].
89+
8290
core.trustctime::
8391
If false, the ctime differences between the index and the
8492
working tree are ignored; useful when the inode change time

Documentation/githooks.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -689,6 +689,26 @@ and "0" meaning they were not.
689689
Only one parameter should be set to "1" when the hook runs. The hook
690690
running passing "1", "1" should not be possible.
691691

692+
virtualFilesystem
693+
~~~~~~~~~~~~~~~~~~
694+
695+
"Virtual File System" allows populating the working directory sparsely.
696+
The projection data is typically automatically generated by an external
697+
process. Git will limit what files it checks for changes as well as which
698+
directories are checked for untracked files based on the path names given.
699+
Git will also only update those files listed in the projection.
700+
701+
The hook is invoked when the configuration option core.virtualFilesystem
702+
is set. It takes one argument, a version (currently 1).
703+
704+
The hook should output to stdout the list of all files in the working
705+
directory that git should track. The paths are relative to the root
706+
of the working directory and are separated by a single NUL. Full paths
707+
('dir1/a.txt') as well as directories are supported (ie 'dir1/').
708+
709+
The exit status determines whether git will use the data from the
710+
hook. On error, git will abort the command with an error message.
711+
692712
GIT
693713
---
694714
Part of the linkgit:git[1] suite

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,6 +1040,7 @@ LIB_OBJS += utf8.o
10401040
LIB_OBJS += varint.o
10411041
LIB_OBJS += version.o
10421042
LIB_OBJS += versioncmp.o
1043+
LIB_OBJS += virtualfilesystem.o
10431044
LIB_OBJS += walker.o
10441045
LIB_OBJS += wildmatch.o
10451046
LIB_OBJS += worktree.o

cache.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -955,6 +955,7 @@ extern char *git_replace_ref_base;
955955

956956
extern int fsync_object_files;
957957
extern int core_preload_index;
958+
extern const char *core_virtualfilesystem;
958959
extern int core_gvfs;
959960
extern int precomposed_unicode;
960961
extern int protect_hfs;

config.c

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1381,7 +1381,11 @@ static int git_default_core_config(const char *var, const char *value, void *cb)
13811381
}
13821382

13831383
if (!strcmp(var, "core.sparsecheckout")) {
1384-
core_apply_sparse_checkout = git_config_bool(var, value);
1384+
/* virtual file system relies on the sparse checkout logic so force it on */
1385+
if (core_virtualfilesystem)
1386+
core_apply_sparse_checkout = 1;
1387+
else
1388+
core_apply_sparse_checkout = git_config_bool(var, value);
13851389
return 0;
13861390
}
13871391

@@ -2372,6 +2376,37 @@ int git_config_get_fsmonitor(void)
23722376
return 0;
23732377
}
23742378

2379+
int git_config_get_virtualfilesystem(void)
2380+
{
2381+
if (git_config_get_pathname("core.virtualfilesystem", &core_virtualfilesystem))
2382+
core_virtualfilesystem = getenv("GIT_VIRTUALFILESYSTEM_TEST");
2383+
2384+
if (core_virtualfilesystem && !*core_virtualfilesystem)
2385+
core_virtualfilesystem = NULL;
2386+
2387+
if (core_virtualfilesystem) {
2388+
/*
2389+
* Some git commands spawn helpers and redirect the index to a different
2390+
* location. These include "difftool -d" and the sequencer
2391+
* (i.e. `git rebase -i`, `git cherry-pick` and `git revert`) and others.
2392+
* In those instances we don't want to update their temporary index with
2393+
* our virtualization data.
2394+
*/
2395+
char *default_index_file = xstrfmt("%s/%s", the_repository->gitdir, "index");
2396+
int should_run_hook = !strcmp(default_index_file, the_repository->index_file);
2397+
2398+
free(default_index_file);
2399+
if (should_run_hook) {
2400+
/* virtual file system relies on the sparse checkout logic so force it on */
2401+
core_apply_sparse_checkout = 1;
2402+
return 1;
2403+
}
2404+
core_virtualfilesystem = NULL;
2405+
}
2406+
2407+
return 0;
2408+
}
2409+
23752410
int git_config_get_index_threads(int *dest)
23762411
{
23772412
int is_bool, val;

config.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -585,6 +585,7 @@ int git_config_get_untracked_cache(void);
585585
int git_config_get_split_index(void);
586586
int git_config_get_max_percent_split_change(void);
587587
int git_config_get_fsmonitor(void);
588+
int git_config_get_virtualfilesystem(void);
588589

589590
/* This dies if the configured or default date is in the future */
590591
int git_config_get_expiry(const char *key, const char **output);

dir.c

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include "ewah/ewok.h"
1919
#include "fsmonitor.h"
2020
#include "submodule-config.h"
21+
#include "virtualfilesystem.h"
2122

2223
/*
2324
* Tells read_directory_recursive how a file or directory should be treated.
@@ -1402,6 +1403,17 @@ enum pattern_match_result path_matches_pattern_list(
14021403
int result = NOT_MATCHED;
14031404
const char *slash_pos;
14041405

1406+
/*
1407+
* The virtual file system data is used to prevent git from traversing
1408+
* any part of the tree that is not in the virtual file system. Return
1409+
* 1 to exclude the entry if it is not found in the virtual file system,
1410+
* else fall through to the regular excludes logic as it may further exclude.
1411+
*/
1412+
if (*dtype == DT_UNKNOWN)
1413+
*dtype = resolve_dtype(DT_UNKNOWN, istate, pathname, pathlen);
1414+
if (is_excluded_from_virtualfilesystem(pathname, pathlen, *dtype) > 0)
1415+
return 1;
1416+
14051417
if (!pl->use_cone_patterns) {
14061418
pattern = last_matching_pattern_from_list(pathname, pathlen, basename,
14071419
dtype, pl, istate);
@@ -1660,8 +1672,20 @@ struct path_pattern *last_matching_pattern(struct dir_struct *dir,
16601672
int is_excluded(struct dir_struct *dir, struct index_state *istate,
16611673
const char *pathname, int *dtype_p)
16621674
{
1663-
struct path_pattern *pattern =
1664-
last_matching_pattern(dir, istate, pathname, dtype_p);
1675+
struct path_pattern *pattern;
1676+
1677+
/*
1678+
* The virtual file system data is used to prevent git from traversing
1679+
* any part of the tree that is not in the virtual file system. Return
1680+
* 1 to exclude the entry if it is not found in the virtual file system,
1681+
* else fall through to the regular excludes logic as it may further exclude.
1682+
*/
1683+
if (*dtype_p == DT_UNKNOWN)
1684+
*dtype_p = resolve_dtype(DT_UNKNOWN, istate, pathname, strlen(pathname));
1685+
if (is_excluded_from_virtualfilesystem(pathname, strlen(pathname), *dtype_p) > 0)
1686+
return 1;
1687+
1688+
pattern = last_matching_pattern(dir, istate, pathname, dtype_p);
16651689
if (pattern)
16661690
return pattern->flags & PATTERN_FLAG_NEGATIVE ? 0 : 1;
16671691
return 0;
@@ -2211,6 +2235,8 @@ static enum path_treatment treat_path(struct dir_struct *dir,
22112235
ignore_case);
22122236
if (dtype != DT_DIR && has_path_in_index)
22132237
return path_none;
2238+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, dtype) > 0)
2239+
return path_excluded;
22142240

22152241
/*
22162242
* When we are looking at a directory P in the working tree,
@@ -2415,6 +2441,8 @@ static void add_path_to_appropriate_result_list(struct dir_struct *dir,
24152441
/* add the path to the appropriate result list */
24162442
switch (state) {
24172443
case path_excluded:
2444+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, DT_DIR) > 0)
2445+
break;
24182446
if (dir->flags & DIR_SHOW_IGNORED)
24192447
dir_add_name(dir, istate, path->buf, path->len);
24202448
else if ((dir->flags & DIR_SHOW_IGNORED_TOO) ||

environment.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ int grafts_replace_parents = 1;
7070
int core_apply_sparse_checkout;
7171
int core_sparse_checkout_cone;
7272
int core_gvfs;
73+
const char *core_virtualfilesystem;
7374
int merge_log_config = -1;
7475
int precomposed_unicode = -1; /* see probe_utf8_pathname_composition() */
7576
unsigned long pack_size_limit_cfg;

read-cache.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include "fsmonitor.h"
2626
#include "thread-utils.h"
2727
#include "progress.h"
28+
#include "virtualfilesystem.h"
2829
#include "gvfs.h"
2930

3031
/* Mask for the name length in ce_flags in the on-disk index */
@@ -1919,6 +1920,7 @@ static void post_read_index_from(struct index_state *istate)
19191920
tweak_untracked_cache(istate);
19201921
tweak_split_index(istate);
19211922
tweak_fsmonitor(istate);
1923+
apply_virtualfilesystem(istate);
19221924
}
19231925

19241926
static size_t estimate_cache_size_from_compressed(unsigned int entries)

0 commit comments

Comments
 (0)