Skip to content

Commit 7c97dc9

Browse files
committed
- fixes missing serializers/deserializers on client update/edit
1 parent cd2fd86 commit 7c97dc9

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

src/kiota/Handlers/BaseKiotaCommandHandler.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@ namespace kiota.Handlers;
2020

2121
internal abstract class BaseKiotaCommandHandler : ICommandHandler, IDisposable
2222
{
23+
protected void DefaultSerializersAndDeserializers(GenerationConfiguration generationConfiguration)
24+
{ // needed until we have rollup packages
25+
var defaultGenerationConfiguration = new GenerationConfiguration();
26+
generationConfiguration.Serializers = defaultGenerationConfiguration.Serializers;
27+
generationConfiguration.Deserializers = defaultGenerationConfiguration.Deserializers;
28+
}
2329
protected TempFolderCachingAccessTokenProvider GetGitHubDeviceStorageService(ILogger logger) => new()
2430
{
2531
Logger = logger,

src/kiota/Handlers/Client/EditHandler.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ public override async Task<int> InvokeAsync(InvocationContext context)
138138
Configuration.Generation.StructuredMimeTypes = new(structuredMimeTypes.SelectMany(static x => x.Split(' ', StringSplitOptions.RemoveEmptyEntries))
139139
.Select(static x => x.TrimQuotes()));
140140

141+
DefaultSerializersAndDeserializers(Configuration.Generation);
141142
var builder = new KiotaBuilder(logger, Configuration.Generation, httpClient, true);
142143
var result = await builder.GenerateClientAsync(cancellationToken).ConfigureAwait(false);
143144
if (result)

src/kiota/Handlers/Client/GenerateHandler.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ public override async Task<int> InvokeAsync(InvocationContext context)
5858
var generationConfiguration = new GenerationConfiguration();
5959
var requests = !refresh && manifest is not null && manifest.ApiDependencies.TryGetValue(clientEntry.Key, out var value) ? value.Requests : [];
6060
clientEntry.Value.UpdateGenerationConfigurationFromApiClientConfiguration(generationConfiguration, clientEntry.Key, requests);
61+
DefaultSerializersAndDeserializers(generationConfiguration);
6162
generationConfiguration.ClearCache = refresh;
6263
generationConfiguration.CleanOutput = refresh;
6364
generationConfiguration.Operation = ClientOperation.Generate;

0 commit comments

Comments
 (0)