Skip to content

Commit eeea787

Browse files
authored
Set the driver argument for getDSN to null by default (#798)
* Added the driver argument to getDSN * Dropped the driver argument but set to null as default * Removed the AE condition in locale support * Modified the AE condition for locale support
1 parent 81ff085 commit eeea787

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

test/functional/pdo_sqlsrv/MsCommon_mid-refactor.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function connect($keywords = '', $options=array(), $errmode = PDO::ERRMODE_EXCEP
7272
* @param bool $disableCE : flag for disabling column encryption even when keystore is NOT none
7373
* @return string dsn string used for PDO constructor
7474
*/
75-
function getDSN($sqlsrvserver, $database, $driver, $keywords = '', $disableCE = false)
75+
function getDSN($sqlsrvserver, $database, $driver = null, $keywords = '', $disableCE = false)
7676
{
7777
require("MsSetup.inc");
7878
$dsn = "";
@@ -85,7 +85,7 @@ function getDSN($sqlsrvserver, $database, $driver, $keywords = '', $disableCE =
8585
if ($database) {
8686
$dsn .= "database=$database;";
8787
}
88-
if ($driver) {
88+
if (!is_null($driver)) {
8989
$dsn .= "driver=$driver;";
9090
}
9191
if ($keystore != "none" && !$disableCE) {

test/functional/sqlsrv/MsCommon.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ function isLocaleSupported()
472472
if (isWindows()) {
473473
return true;
474474
}
475-
if (AE\isColEncrypted()) {
475+
if (AE\isDataEncrypted()) {
476476
return false;
477477
}
478478
// now check ODBC version

0 commit comments

Comments
 (0)