Skip to content

Commit f5be531

Browse files
author
Hadis Fard
authored
Merge pull request #449 from yitam/extensionVer
fix ExtensionVer regex
2 parents 1d1d285 + f1872d5 commit f5be531

File tree

6 files changed

+5
-14
lines changed

6 files changed

+5
-14
lines changed

test/bvt/pdo_sqlsrv/msdn_pdo_getAttribute.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@ Array
3535
\[DriverDllName\] => msodbcsql[0-9]{2}\.dll|libmsodbcsql-[0-9]{2}\.[0-9]\.so\.[0-9]\.[0-9]
3636
\[DriverODBCVer\] => [0-9]{1,2}\.[0-9]{1,2}
3737
\[DriverVer\] => [0-9]{1,2}\.[0-9]{1,2}\.[0-9]{4}
38-
\[ExtensionVer\] => [0-9]\.[0-9]\.[0-9](\-((rc)|(preview))(\.[0-9]+)?)?(\+[0-9]+)?
38+
\[ExtensionVer\] => [0-9].[0-9]\.[0-9](-(RC[0-9]?|preview))?(\.[0-9]+)?(\+[0-9]+)?
3939
\)

test/bvt/sqlsrv/msdn_sqlsrv_client_info.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,4 @@ sqlsrv_close( $conn);
3232
DriverDllName: msodbcsql[0-9]{2}\.dll|libmsodbcsql-[0-9]{2}\.[0-9]\.so\.[0-9]\.[0-9]
3333
DriverODBCVer: [0-9]{1,2}\.[0-9]{1,2}
3434
DriverVer: [0-9]{1,2}\.[0-9]{1,2}\.[0-9]{4}
35-
ExtensionVer: [0-9]\.[0-9]\.[0-9](\-((rc)|(preview))(\.[0-9]+)?)?(\+[0-9]+)?
35+
ExtensionVer: [0-9].[0-9]\.[0-9](-(RC[0-9]?|preview))?(\.[0-9]+)?(\+[0-9]+)?

test/pdo_sqlsrv/pdo_getAttribute_clientInfo.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ Array
1818
\[(DriverDllName|DriverName)\] => (msodbcsql1[1-9].dll|libmsodbcsql-[1-9]{2}.[0-9].so.[0-9].[0-9])
1919
\[DriverODBCVer\] => [0-9]{1,2}\.[0-9]{1,2}
2020
\[DriverVer\] => [0-9]{1,2}\.[0-9]{1,2}\.[0-9]{4}
21-
\[ExtensionVer\] => [0-9]\.[0-9]\.[0-9](\-((rc)|(preview))(\.[0-9]+)?)?(\+[0-9]+)?
21+
\[ExtensionVer\] => [0-9].[0-9]\.[0-9](-(RC[0-9]?|preview))?(\.[0-9]+)?(\+[0-9]+)?
2222
\)

test/pdo_sqlsrv/pdo_get_set_attr.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ array\(4\) {
145145
\["DriverVer"\]=>
146146
string\(10\) "[0-9]{2}.[0-9]{2}.[0-9]{4}"
147147
\["ExtensionVer"\]=>
148-
string\([0-9]*\) \"[0-9]\.[0-9]\.[0-9](\-((rc)|(preview))(\.[0-9]+)?)?(\+[0-9]+)?\"
148+
string\([0-9]*\) \"[0-9].[0-9]\.[0-9](-(RC[0-9]?|preview))?(\.[0-9]+)?(\+[0-9]+)?\"
149149
}
150150

151151
Test_6:

test/sqlsrv/sqlsrv_2008_dataTypes.phpt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ if( !$conn ) {
2020
FatalError("Could not connect");
2121
}
2222

23-
print_r( sqlsrv_client_info( $conn ));
24-
2523
$stmt = sqlsrv_query( $conn, "IF OBJECT_ID('2008_date_types', 'U') IS NOT NULL DROP TABLE [2008_date_types]" );
2624

2725
$stmt = sqlsrv_query( $conn, "CREATE TABLE [2008_date_types] (id int, [c1_date] date, [c2_time] time, [c3_datetimeoffset] datetimeoffset, [c4_datetime2] datetime2)" );
@@ -104,13 +102,6 @@ sqlsrv_close( $conn );
104102

105103
?>
106104
--EXPECTREGEX--
107-
Array
108-
\(
109-
\[(DriverDllName|DriverName)\] => msodbcsql[0-9]{2}\.dll|libmsodbcsql-[0-9]{2}\.[0-9]\.so\.[0-9]\.[0-9]
110-
\[DriverODBCVer\] => [0-9]{1,2}\.[0-9]{1,2}
111-
\[DriverVer\] => [0-9]{1,2}\.[0-9]{1,2}\.[0-9]{4}
112-
\[ExtensionVer\] => [0-9]\.[0-9]\.[0-9](\-((rc)|(preview))(\.[0-9]+)?)?(\+[0-9]+)?
113-
\)
114105
field 0 = [0-9]{1,5}
115106
field 1 = [0-9]{4}\-[0-9]{2}\-[0-9]{2}
116107
field 2 = [0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{7}

test/sqlsrv/sqlsrv_client_info.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@ array\(4\) {
2121
\[\"DriverVer\"\]=>
2222
string\(10\) \"[0-9]{1,2}\.[0-9]{1,2}\.[0-9]{4}\"
2323
\[\"ExtensionVer\"\]=>
24-
string\([0-9]+\) \"[0-9]\.[0-9]\.[0-9](\-((rc)|(preview))(\.[0-9]+)?)?(\+[0-9]+)?"
24+
string\([0-9]+\) \"[0-9].[0-9]\.[0-9](-(RC[0-9]?|preview))?(\.[0-9]+)?(\+[0-9]+)?\"
2525
}

0 commit comments

Comments
 (0)