Skip to content

Commit 038cac7

Browse files
Copilotjustinchuby
andauthored
Move _c_api_utils.py to version_converter package (#2401)
This PR moves `_c_api_utils.py` from `onnxscript/ir/passes/common/` to `onnxscript/version_converter/` since it's only used by the version converter module. ## Changes - Moved `onnxscript/ir/passes/common/_c_api_utils.py` to `onnxscript/version_converter/_c_api_utils.py` - Updated import in `onnxscript/version_converter/__init__.py` from `from onnxscript.ir.passes.common import _c_api_utils` to `from . import _c_api_utils` ## Analysis A codebase analysis confirmed that `_c_api_utils.py` is only imported and used by the version converter: - The file contains utilities for interfacing with ONNX C APIs, specifically the `call_onnx_api` function - It's only imported in `onnxscript/version_converter/__init__.py` - It's not exported in any `__all__` lists - No other modules reference or use this utility Moving the file to the version converter package improves code organization by colocating the utility with its sole consumer. Fixes #2400. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: justinchuby <[email protected]> Co-authored-by: Justin Chu <[email protected]>
1 parent 3b850e5 commit 038cac7

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

onnxscript/version_converter/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
import onnxscript.ir.passes
1515
import onnxscript.ir.passes.common
1616
from onnxscript import ir
17-
from onnxscript.ir.passes.common import _c_api_utils
18-
from onnxscript.version_converter import _version_converter
17+
from onnxscript.version_converter import _c_api_utils, _version_converter
1918

2019
logger = logging.getLogger(__name__)
2120

0 commit comments

Comments
 (0)