Skip to content

Commit 9439e10

Browse files
authored
fix(ci): do not submit sarif on drafts to make reviewing easier (#328)
Do not submit sarif on drafts to make reviewing easier, but always run lintrunner. Follow up of #326
1 parent 3ce89ef commit 9439e10

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/lint.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ jobs:
3636
enforce-style:
3737
name: Enforce style
3838
runs-on: ubuntu-latest
39-
# Do not run on drafts to make reviewing easier
40-
if: github.event.pull_request.draft == false
4139
steps:
4240
- uses: actions/checkout@v3
4341
- name: Setup Python
@@ -72,7 +70,8 @@ jobs:
7270
run: |
7371
python -m lintrunner_adapters to-sarif lint.json lintrunner.sarif
7472
- name: Upload SARIF file
75-
if: always()
73+
# Do not display on drafts to make reviewing easier
74+
if: github.event.pull_request.draft == false
7675
continue-on-error: true
7776
uses: github/codeql-action/upload-sarif@v2
7877
with:

0 commit comments

Comments
 (0)