Skip to content

Commit 9a565a8

Browse files
committed
Update base for Update on "feat(atenlib): create tests with OpInfo"
[ghstack-poisoned]
1 parent d1c210b commit 9a565a8

File tree

8 files changed

+38
-5
lines changed

8 files changed

+38
-5
lines changed

onnxscript/function_libs/tools/torch_aten/generate_aten_signatures.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import os
1313
import textwrap
1414
import typing
15-
from typing import Any, Optional, Sequence
15+
from typing import Any, Sequence
1616

1717
import torchgen.gen
1818
import torchgen.model
@@ -48,21 +48,22 @@ def parse_native_functions_yaml(yaml_path: str) -> tuple[Any, Any]:
4848

4949
def create_list_type(arg: torchgen.model.Argument) -> cg.TypeRef:
5050
assert isinstance(arg.type, torchgen.model.ListType), f"arg: {arg}"
51-
arg_type = arg_type_to_str(arg.type, default=arg.default)
51+
arg_type = arg_type_to_str(arg.type)
5252
if type_is_builtin(arg_type):
5353
return cg.TypingRefs.Sequence(cg.BuiltinTypeRef(arg_type))
5454
if arg_type == "TensorType":
5555
return cg.TypingRefs.Sequence(cg.TypeRef("onnxscript", "TensorType"))
5656
return cg.TypeRef("onnxscript", arg_type)
57-
# TODO: Enable this once we have better typing support for generics.
57+
58+
# TODO(justinchuby): Enable this when generics are better supported
5859
# if arg.type.size is None:
5960
# # INT64[...]
6061
# return cg.TypeRef("onnxscript", arg_type, cg.EllipsisTypeRef())
6162
# # INT64[3]
6263
# return cg.TypeRef("onnxscript", arg_type, *[cg.TypeRef(None, f"{arg.type.size}")])
6364

6465

65-
def arg_type_to_str(arg_type: torchgen.model.Type, default: Optional[str] = None) -> str:
66+
def arg_type_to_str(arg_type: torchgen.model.Type) -> str:
6667
if arg_type.is_base_ty_like(torchgen.model.BaseTy.Tensor):
6768
return "TensorType"
6869
elif arg_type.is_base_ty_like(torchgen.model.BaseTy.SymInt):
@@ -94,7 +95,7 @@ def get_argument_type(arg: torchgen.model.Argument) -> cg.TypeRef:
9495
if isinstance(arg.type, torchgen.model.ListType):
9596
inner_node = create_list_type(arg)
9697
else:
97-
arg_type_str = arg_type_to_str(arg.type, default=arg.default)
98+
arg_type_str = arg_type_to_str(arg.type)
9899
if type_is_builtin(arg_type_str):
99100
inner_node = cg.BuiltinTypeRef(arg_type_str)
100101
else:
@@ -257,6 +258,10 @@ def copyright_header() -> str:
257258
# Copyright (c) Microsoft Corporation. All rights reserved.
258259
# Licensed under the MIT License.
259260
{dashline}
261+
# mypy: disable-error-code=misc
262+
# mypy: disable-error-code=type-arg
263+
# mypy: disable-error-code=valid-type
264+
# mypy: disable-error-code=assignment
260265
"""
261266
)
262267

onnxscript/function_libs/torch_aten/ops/core.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# Licensed under the MIT License.
44
# --------------------------------------------------------------------------
5+
# mypy: disable-error-code=misc
6+
# mypy: disable-error-code=type-arg
7+
# mypy: disable-error-code=valid-type
8+
# mypy: disable-error-code=assignment
59
"""torch.ops.aten operators under the `core` module.
610
711
- No inplace operators.

onnxscript/function_libs/torch_aten/ops/fft.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# Licensed under the MIT License.
44
# --------------------------------------------------------------------------
5+
# mypy: disable-error-code=misc
6+
# mypy: disable-error-code=type-arg
7+
# mypy: disable-error-code=valid-type
8+
# mypy: disable-error-code=assignment
59
"""torch.ops.aten operators under the `fft` module.
610
711
- No inplace operators.

onnxscript/function_libs/torch_aten/ops/linalg.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# Licensed under the MIT License.
44
# --------------------------------------------------------------------------
5+
# mypy: disable-error-code=misc
6+
# mypy: disable-error-code=type-arg
7+
# mypy: disable-error-code=valid-type
8+
# mypy: disable-error-code=assignment
59
"""torch.ops.aten operators under the `linalg` module.
610
711
- No inplace operators.

onnxscript/function_libs/torch_aten/ops/nested.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# Licensed under the MIT License.
44
# --------------------------------------------------------------------------
5+
# mypy: disable-error-code=misc
6+
# mypy: disable-error-code=type-arg
7+
# mypy: disable-error-code=valid-type
8+
# mypy: disable-error-code=assignment
59
"""torch.ops.aten operators under the `nested` module.
610
711
- No inplace operators.

onnxscript/function_libs/torch_aten/ops/nn.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# Licensed under the MIT License.
44
# --------------------------------------------------------------------------
5+
# mypy: disable-error-code=misc
6+
# mypy: disable-error-code=type-arg
7+
# mypy: disable-error-code=valid-type
8+
# mypy: disable-error-code=assignment
59
"""torch.ops.aten operators under the `nn` module.
610
711
- No inplace operators.

onnxscript/function_libs/torch_aten/ops/sparse.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# Licensed under the MIT License.
44
# --------------------------------------------------------------------------
5+
# mypy: disable-error-code=misc
6+
# mypy: disable-error-code=type-arg
7+
# mypy: disable-error-code=valid-type
8+
# mypy: disable-error-code=assignment
59
"""torch.ops.aten operators under the `sparse` module.
610
711
- No inplace operators.

onnxscript/function_libs/torch_aten/ops/special.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# Licensed under the MIT License.
44
# --------------------------------------------------------------------------
5+
# mypy: disable-error-code=misc
6+
# mypy: disable-error-code=type-arg
7+
# mypy: disable-error-code=valid-type
8+
# mypy: disable-error-code=assignment
59
"""torch.ops.aten operators under the `special` module.
610
711
- No inplace operators.

0 commit comments

Comments
 (0)