Skip to content

[torchlib] Implement different padding modes #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
justinchuby opened this issue Nov 8, 2023 · 3 comments
Open

[torchlib] Implement different padding modes #1138

justinchuby opened this issue Nov 8, 2023 · 3 comments
Assignees
@xiaowuhu
Labels
low priority module: torchlib Related to the torch/aten function lib in development

Comments

@justinchuby
Copy link
Collaborator

justinchuby commented Nov 8, 2023 •
edited
Loading

aten.reflection_pad1d.default for STFT: pytorch/pytorch#113067 (comment)

And other modes

  • reflection_pad
  • replication_pad

Reference: https://github.com/pytorch/pytorch/blob/e2236ae097eb25dbdbeb740373f93643a4e70f6b/torch/onnx/symbolic_opset11.py#L800-L810

cc @fatcat-z @xiaowuhu
@justinchuby justinchuby mentioned this issue Nov 8, 2023
Open
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Nov 8, 2023
@justinchuby justinchuby changed the title [torchlib] Implement reflection pad for STFT [torchlib] Implement different padding modes Nov 9, 2023
@justinchuby justinchuby mentioned this issue Nov 13, 2023
Open
@xiaowuhu
Copy link
Contributor

xiaowuhu commented Dec 5, 2023

#1203

@justinchuby
Copy link
Collaborator Author

https://github.com/pytorch/pytorch/pull/115113/files

@justinchuby
Copy link
Collaborator Author

justinchuby commented Dec 12, 2023 •
edited
Loading

We may be able to deprioritize this a little because pytorch is implementing decompositions for them. @xiaowuhu let me know if that sounds good to you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaowuhu xiaowuhu

Labels
low priority module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinchuby @xiaowuhu