Skip to content

[torchlib] torch.ops.aten.im2col #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BowenBao opened this issue Mar 7, 2024 · 0 comments
Open

[torchlib] torch.ops.aten.im2col #1290

BowenBao opened this issue Mar 7, 2024 · 0 comments
Labels
low priority module: torchlib Related to the torch/aten function lib in development

Comments

@BowenBao
Copy link
Contributor

BowenBao commented Mar 7, 2024

Since torchlib does not have an implementation for this op, the op is being decomposed by dynamo onnx exporter during export. There is a performance concern regarding unnecessary upcasting in the aforementioned decomposition, discussed more in pytorch/pytorch#121363.

On the other hand, the decomposition emits aten::index, which is exported as onnx::GatherND. Within the context of im2col, it is possible to instead export using onnx::Gather. It is unclear if the latter approach would yield higher performance.

Depending on both above factors, it might become appealing to add the im2col implementation in torchlib. Marking as low priority for now and no immediate action required.

@BowenBao BowenBao added module: torchlib Related to the torch/aten function lib in development low priority labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

No branches or pull requests

1 participant