From 86643c53a0ca60c26d62a2f1153701375401db02 Mon Sep 17 00:00:00 2001 From: Johansmm Date: Tue, 11 Mar 2025 08:07:44 +0100 Subject: [PATCH] fix(ir): update scoped_values (#2093) Show there is a bug when deserializing NodeProto with inputs/outputs. For deserialize to work without context, it is necessary that the first element be an empty dict. --- onnxscript/ir/serde.py | 2 +- onnxscript/ir/serde_test.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/onnxscript/ir/serde.py b/onnxscript/ir/serde.py index 4988562030..188c5eafc9 100644 --- a/onnxscript/ir/serde.py +++ b/onnxscript/ir/serde.py @@ -958,7 +958,7 @@ def _deserialize_attribute( def deserialize_node(proto: onnx.NodeProto) -> _core.Node: return _deserialize_node( - proto, scoped_values=[], value_info={}, quantization_annotations={} + proto, scoped_values=[{}], value_info={}, quantization_annotations={} ) diff --git a/onnxscript/ir/serde_test.py b/onnxscript/ir/serde_test.py index b4d13ebdea..416020afeb 100644 --- a/onnxscript/ir/serde_test.py +++ b/onnxscript/ir/serde_test.py @@ -18,7 +18,7 @@ class ConvenienceFunctionsTest(unittest.TestCase): [ ("model", onnx.ModelProto()), ("graph", onnx.GraphProto()), - ("node", onnx.NodeProto()), + ("node", onnx.NodeProto(input=["X"], output=["Y"])), ( "tensor", onnx.helper.make_tensor("test_tensor", onnx.TensorProto.FLOAT, [1], [1.0]),