Double click action title

Author: agg23

playwright/_impl/_frame.py

@@ -513,7 +513,9 @@ async def dblclick(
         strict: bool = None,
         trial: bool = None,
     ) -> None:
-        await self._channel.send("dblclick", locals_to_params(locals()))
+        await self._channel.send(
+            "dblclick", locals_to_params(locals()), title="Double click"
+        )
 
     async def tap(
         self,

playwright/_impl/_input.py

@@ -61,6 +61,17 @@ async def up(
     ) -> None:
         await self._channel.send("mouseUp", locals_to_params(locals()))
 
+    async def _click(
+        self,
+        x: float,
+        y: float,
+        delay: float = None,
+        button: MouseButton = None,
+        clickCount: int = None,
+        title: str = None,
+    ) -> None:
+        await self._channel.send("mouseClick", locals_to_params(locals()), title=title)
+
     async def click(
         self,
         x: float,
@@ -69,7 +80,7 @@ async def click(
         button: MouseButton = None,
         clickCount: int = None,
     ) -> None:
-        await self._channel.send("mouseClick", locals_to_params(locals()))
+        await self._click(**locals())
 
     async def dblclick(
         self,
@@ -78,7 +89,9 @@ async def dblclick(
         delay: float = None,
         button: MouseButton = None,
     ) -> None:
-        await self.click(x, y, delay=delay, button=button, clickCount=2)
+        await self._click(
+            x, y, delay=delay, button=button, clickCount=2, title="Double click"
+        )
 
     async def wheel(self, deltaX: float, deltaY: float) -> None:
         await self._channel.send("mouseWheel", locals_to_params(locals()))

tests/async/test_tracing.py

@@ -152,8 +152,7 @@ async def test_should_collect_trace_with_resources_but_no_js(
                 re.compile(r"Set content"),
                 re.compile(r"Click"),
                 re.compile(r"Mouse move"),
-                # TODO: Roll: Switch to Double click
-                re.compile(r"Click"),
+                re.compile(r"Double click"),
                 re.compile(r'Insert "abc"'),
                 re.compile(r"Wait for timeout"),
                 re.compile(r'Navigate to "/empty\.html"'),
@@ -234,8 +233,7 @@ async def test_should_collect_two_traces(
     async with show_trace_viewer(tracing2_path) as trace_viewer:
         await expect(trace_viewer.action_titles).to_have_text(
             [
-                # TODO: Roll: Switch to Double click
-                re.compile(r"Click"),
+                re.compile(r"Double click"),
                 re.compile(r"Close"),
             ]
         )

tests/sync/test_tracing.py

@@ -154,8 +154,7 @@ def test_should_collect_trace_with_resources_but_no_js(
                 re.compile(r"Set content"),
                 re.compile(r"Click"),
                 re.compile(r"Mouse move"),
-                # TODO: Roll: Switch to Double click
-                re.compile(r"Click"),
+                re.compile(r"Double click"),
                 re.compile(r'Insert "abc"'),
                 re.compile(r"Wait for timeout"),
                 re.compile(r'Navigate to "/empty\.html"'),
@@ -237,8 +236,7 @@ def test_should_collect_two_traces(
     with show_trace_viewer(tracing2_path) as trace_viewer:
         expect(trace_viewer.action_titles).to_have_text(
             [
-                # TODO: Roll: Switch to Double click
-                re.compile(r"Click"),
+                re.compile(r"Double click"),
                 re.compile(r"Close"),
             ]
         )