Skip to content

Commit 07c1a27

Browse files
authored
chore(deps): prepare deps for monorepo (#13057)
1 parent 7a67c6d commit 07c1a27

File tree

5 files changed

+365
-121
lines changed

5 files changed

+365
-121
lines changed

packages/playwright-core/src/DEPS

Lines changed: 258 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,258 @@
1+
module.exports = {
2+
'browserServerImpl.ts': [ '**' ],
3+
4+
// CLI should only use client-side features.
5+
'cli/': [
6+
'cli/**',
7+
'client/**',
8+
'debug/injected/',
9+
'generated/',
10+
'grid/**',
11+
'server/injected/',
12+
'server/trace/**',
13+
'utils/**',
14+
],
15+
16+
'cli/driver.ts': [ '**' ],
17+
18+
// Client depends on chromium protocol for types.
19+
'client/': [
20+
'common/',
21+
'protocol/',
22+
'server/chromium/protocol.d.ts',
23+
'utils/',
24+
],
25+
26+
'dispatchers/': [
27+
'common/',
28+
'protocol/',
29+
'server/**',
30+
'utils/'
31+
],
32+
33+
// Grid
34+
'grid/': [
35+
'client/',
36+
'dispatchers/**',
37+
'server/',
38+
'utils/**',
39+
],
40+
41+
'inProcessFactory.ts': [ '**' ],
42+
43+
'outofprocess.ts': [
44+
'client/',
45+
'protocol/',
46+
'utils/'
47+
],
48+
49+
'protocol/': [
50+
'utils/'
51+
],
52+
53+
// Generic dependencies for server-side code.
54+
'server/': [
55+
'common/',
56+
'generated/',
57+
'protocol/**',
58+
// Can depend on any files in these subdirectories.
59+
'server/',
60+
// Can depend on files directly in the server directory.
61+
'server/common/**',
62+
'server/injected/**',
63+
'server/supplements/**',
64+
'utils/',
65+
],
66+
67+
// No dependencies for code shared between node and page.
68+
'server/common/': [],
69+
70+
// Strict dependencies for injected code.
71+
'server/injected/': [
72+
'server/common/', 'protocol/channels.ts'
73+
],
74+
75+
// Electron and Clank use chromium internally.
76+
'server/android/': [
77+
'common/',
78+
'generated/',
79+
'protocol/',
80+
'protocol/**',
81+
'server/',
82+
'server/chromium/',
83+
'server/common/**',
84+
'server/injected/**',
85+
'server/supplements/**',
86+
'utils/',
87+
],
88+
89+
'server/browserContext.ts': [
90+
'common/',
91+
'generated/',
92+
'protocol/**',
93+
'server/',
94+
'server/common/**',
95+
'server/injected/**',
96+
'server/supplements/**',
97+
'server/trace/recorder/tracing.ts',
98+
'utils/',
99+
],
100+
101+
'server/electron/': [
102+
'common/',
103+
'generated/',
104+
'protocol/**',
105+
'server/',
106+
'server/chromium/',
107+
'server/common/**',
108+
'server/injected/**',
109+
'server/supplements/**',
110+
'utils/',
111+
],
112+
113+
'server/fetch.ts': [
114+
'common/',
115+
'generated/',
116+
'protocol/**',
117+
'server/',
118+
'server/common/**',
119+
'server/injected/**',
120+
'server/supplements/**',
121+
'server/trace/recorder/tracing.ts',
122+
'utils/',
123+
],
124+
125+
'server/playwright.ts': [
126+
'common/',
127+
'generated/',
128+
'protocol/**',
129+
'server/',
130+
'server/android/',
131+
'server/chromium/',
132+
'server/common/**',
133+
'server/electron/',
134+
'server/firefox/',
135+
'server/injected/**',
136+
'server/supplements/**',
137+
'server/webkit/',
138+
'utils/',
139+
],
140+
141+
'server/supplements/recorder/recorderApp.ts': [
142+
'common/',
143+
'server/',
144+
'server/chromium/',
145+
'utils/',
146+
],
147+
148+
'server/supplements/recorderSupplement.ts': [
149+
'common/',
150+
'generated/',
151+
'protocol/**',
152+
'server/',
153+
'server/common/**',
154+
'server/injected/**',
155+
'server/snapshot/',
156+
'server/supplements/**',
157+
'utils/',
158+
],
159+
160+
161+
// Trace viewer
162+
'server/trace/common/': [
163+
'common/',
164+
'generated/',
165+
'protocol/**',
166+
'server/',
167+
'server/common/**',
168+
'server/injected/**',
169+
'server/snapshot/',
170+
'server/supplements/**',
171+
'utils/',
172+
],
173+
174+
'server/trace/recorder/': [
175+
'common/',
176+
'generated/',
177+
'protocol/**',
178+
'server/',
179+
'server/common/**',
180+
'server/injected/**',
181+
'server/snapshot/',
182+
'server/supplements/**',
183+
'server/trace/common/',
184+
'utils/',
185+
],
186+
187+
'server/trace/viewer/': [
188+
'common/',
189+
'generated/',
190+
'protocol/**',
191+
'server/',
192+
'server/chromium/',
193+
'server/common/**',
194+
'server/injected/**',
195+
'server/snapshot/',
196+
'server/supplements/**',
197+
'server/trace/common/',
198+
'server/trace/recorder/',
199+
'utils/',
200+
],
201+
202+
// The service is a cross-cutting feature, and so it depends on a bunch of things.
203+
'remote/': [
204+
'client/',
205+
'debug/',
206+
'dispatchers/',
207+
'server/',
208+
'server/electron/',
209+
'server/supplements/',
210+
'server/trace/',
211+
'utils/**',
212+
],
213+
214+
'utils/': [
215+
'common/',
216+
'protocol/',
217+
'third_party/diff_match_patch',
218+
],
219+
220+
// Tracing is a client/server plugin, nothing should depend on it.
221+
'web/components/': [
222+
'third_party/highlightjs/**',
223+
'web/third_party/vscode/',
224+
],
225+
226+
'web/recorder/': [
227+
'common/',
228+
'server/supplements/recorder/recorderTypes.ts',
229+
'web/',
230+
'web/components/',
231+
'web/third_party/vscode/',
232+
],
233+
234+
'web/traceViewer/': [
235+
'common/',
236+
'protocol/callMetadata.ts',
237+
'server/trace/common/',
238+
'web/',
239+
'web/third_party/vscode/',
240+
'web/traceViewer/ui/',
241+
],
242+
243+
'web/traceViewer/ui/': [
244+
'common/',
245+
'protocol/',
246+
'protocol/channels.ts',
247+
'server/snapshot/snapshotTypes.ts',
248+
'server/trace/',
249+
'server/trace/common/',
250+
'server/trace/viewer/',
251+
'third_party/**',
252+
'web/',
253+
'web/components/',
254+
'web/traceViewer/',
255+
],
256+
257+
'web/traceViewer/inMemorySnapshotter.ts': [ '**' ],
258+
}

packages/playwright-core/src/client/cdpSession.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
import * as channels from '../protocol/channels';
1818
import { ChannelOwner } from './channelOwner';
19-
import { Protocol } from '../server/chromium/protocol';
20-
import * as api from '../../types/types';
19+
import type { Protocol } from '../server/chromium/protocol';
20+
import type * as api from '../../types/types';
2121

2222
export class CDPSession extends ChannelOwner<channels.CDPSessionChannel> implements api.CDPSession {
2323
static from(cdpSession: channels.CDPSessionChannel): CDPSession {

packages/playwright-test/src/DEPS

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
module.exports = {
2+
'/': [
3+
'reporters/',
4+
'third_party/',
5+
'matchers/',
6+
],
7+
'matchers': [
8+
'expect.ts',
9+
'globals.ts',
10+
'testInfo.ts',
11+
'types.ts',
12+
'util.ts',
13+
],
14+
'reporters': [
15+
'util.ts'
16+
],
17+
};

packages/playwright-test/src/matchers/matchers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import { Locator, Page, APIResponse } from 'playwright-core';
18-
import { FrameExpectOptions } from 'playwright-core/lib/client/types';
18+
import type { FrameExpectOptions } from 'playwright-core/lib/client/types';
1919
import { constructURLBasedOnBaseURL } from 'playwright-core/lib/utils/utils';
2020
import type { Expect } from '../types';
2121
import { expectTypes, callLogText } from '../util';

0 commit comments

Comments
 (0)