Skip to content

Commit 5648eac

Browse files
authored
browser(webkit): fix mac build after last roll (#4108)
1 parent 3f68713 commit 5648eac

File tree

3 files changed

+6
-48
lines changed

3 files changed

+6
-48
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
1351
2-
Changed: [email protected] Fri Oct 9 14:37:22 PDT 2020
1+
1352
2+
Changed: [email protected] Fri Oct 9 16:06:24 PDT 2020

browser_patches/webkit/embedder/Playwright/mac/AppDelegate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ - (WKWebViewConfiguration *)defaultConfiguration
237237
configuration.preferences._requestAnimationFrameEnabled = YES;
238238
_WKProcessPoolConfiguration *processConfiguration = [[[_WKProcessPoolConfiguration alloc] init] autorelease];
239239
processConfiguration.forceOverlayScrollbars = YES;
240-
configuration.processPool = [[[WKProcessPool alloc] _initWithConfiguration:processConfiguration AndDataStore:configuration.websiteDataStore] autorelease];
240+
configuration.processPool = [[[WKProcessPool alloc] _initWithConfiguration:processConfiguration] autorelease];
241241
}
242242
return configuration;
243243
}

browser_patches/webkit/patches/bootstrap.diff

Lines changed: 3 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -6738,49 +6738,6 @@ index b6388155cd3036e666110f1925616afd37e868ba..c21275123dc4581f51730a2d27deac37
67386738
} WKPageUIClientV14;
67396739

67406740
#ifdef __cplusplus
6741-
diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm b/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
6742-
index e795b3326c76df9d9d840342f8dd14bbbfa107db..e64dad4d6185aa74cd42c60b749aa3b48df93e5f 100644
6743-
--- a/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
6744-
+++ b/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
6745-
@@ -47,6 +47,7 @@
6746-
#import "_WKDownloadDelegate.h"
6747-
#import "_WKDownloadInternal.h"
6748-
#import "_WKProcessPoolConfigurationInternal.h"
6749-
+#import "_WKWebsiteDataStoreInternal.h"
6750-
#import <WebCore/CertificateInfo.h>
6751-
#import <WebCore/HTTPCookieAcceptPolicyCocoa.h>
6752-
#import <WebCore/PluginData.h>
6753-
@@ -86,6 +87,18 @@ static WKProcessPool *sharedProcessPool;
6754-
return self;
6755-
}
6756-
6757-
+- (instancetype)_initWithConfiguration:(_WKProcessPoolConfiguration *)configuration AndDataStore:(WKWebsiteDataStore*)dataStore
6758-
+{
6759-
+ if (!(self = [super init]))
6760-
+ return nil;
6761-
+
6762-
+ API::Object::constructInWrapper<WebKit::WebProcessPool>(self, *configuration->_processPoolConfiguration);
6763-
+ _processPool->setPrimaryDataStore(*dataStore->_websiteDataStore);
6764-
+
6765-
+ return self;
6766-
+}
6767-
+
6768-
+
6769-
- (instancetype)init
6770-
{
6771-
return [self _initWithConfiguration:adoptNS([[_WKProcessPoolConfiguration alloc] init]).get()];
6772-
diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h b/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
6773-
index 21941b2d46070da1ca95fb906f8832f5af04d8ab..2b688d383c8ae1a88dc44a11f53ae724fc13ad1a 100644
6774-
--- a/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
6775-
+++ b/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
6776-
@@ -38,6 +38,7 @@
6777-
6778-
@interface WKProcessPool ()
6779-
- (instancetype)_initWithConfiguration:(_WKProcessPoolConfiguration *)configuration __attribute__((objc_method_family(init))) NS_DESIGNATED_INITIALIZER;
6780-
+- (instancetype)_initWithConfiguration:(_WKProcessPoolConfiguration *)configuration AndDataStore:(WKWebsiteDataStore *)dataStore __attribute__((objc_method_family(init))) NS_DESIGNATED_INITIALIZER;
6781-
@end
6782-
6783-
@interface WKProcessPool (WKPrivate)
67846741
diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h b/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h
67856742
index cad87f3ef2ab93d93a74cec0c34b47c695de6bc6..66145a384638b97ee08516e56e1e86a83713c634 100644
67866743
--- a/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h
@@ -8370,10 +8327,10 @@ index b0722e7da81e56530deb570b82ed7cfece970362..05ec3e3ea97ba49135a27d7f9b91f14c
83708327
}
83718328
diff --git a/Source/WebKit/UIProcess/Inspector/Agents/InspectorScreencastAgent.cpp b/Source/WebKit/UIProcess/Inspector/Agents/InspectorScreencastAgent.cpp
83728329
new file mode 100644
8373-
index 0000000000000000000000000000000000000000..e6fb1922885d4650f6adb1ddd758fe5c7c7ea6f5
8330+
index 0000000000000000000000000000000000000000..3873c71090213157a982c0d20316428de098c77b
83748331
--- /dev/null
83758332
+++ b/Source/WebKit/UIProcess/Inspector/Agents/InspectorScreencastAgent.cpp
8376-
@@ -0,0 +1,167 @@
8333+
@@ -0,0 +1,168 @@
83778334
+/*
83788335
+ * Copyright (C) 2020 Microsoft Corporation.
83798336
+ *
@@ -8405,6 +8362,7 @@ index 0000000000000000000000000000000000000000..e6fb1922885d4650f6adb1ddd758fe5c
84058362
+#include "GenericCallback.h"
84068363
+#include "PageClient.h"
84078364
+#include "ScreencastEncoder.h"
8365+
+#include "WebPageInspectorController.h"
84088366
+#include "WebPageProxy.h"
84098367
+#include "WebsiteDataStore.h"
84108368
+#include <JavaScriptCore/InspectorFrontendDispatchers.h>

0 commit comments

Comments
 (0)